Network traffic annotation added to affiliation_fetcher.

components/password_manager/core/browser/affiliation_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/affiliation_fetcher.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "components/password_manager/core/browser/affiliation_api.pb.h"
 #include "components/password_manager/core/browser/affiliation_utils.h"
 #include "components/password_manager/core/browser/test_affiliation_fetcher_factory.h"
 #include "google_apis/google_api_keys.h"
 #include "net/base/load_flags.h"
 #include "net/base/url_util.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "url/gurl.h"
 
 namespace password_manager {
 
 namespace {
 
 // Enumeration listing the possible outcomes of fetching affiliation information
 // from the Affiliation API. This is used in UMA histograms, so do not change
@@ skipping 55 matching lines @@
 
 // static
 void AffiliationFetcher::SetFactoryForTesting(
     TestAffiliationFetcherFactory* factory) {
   g_testing_factory = factory;
 }
 
 void AffiliationFetcher::StartRequest() {
   DCHECK(!fetcher_);
 
-  fetcher_ =
-      net::URLFetcher::Create(BuildQueryURL(), net::URLFetcher::POST, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("android_affiliation", R"(

[engedy, 2017/02/21 12:39:18]

nit: How about affiliation_lookup?

[Ramin Halavati, 2017/02/21 13:12:02]

Done.

+        semantics {
+          sender: "Affiliation Fetcher"
+          description:
+            "Password storage of users syncing their passwords to Google "

[engedy, 2017/02/21 12:39:18]

Suggestion for first sentence:

Users syncing their passwords may have credentials stored for Android apps.
Unless synced data is encrypted with a custom passphrase, this service ...

[Ramin Halavati, 2017/02/21 13:12:02]

Done.

+            "without a custom passphrase may contain credentials for Android "
+            "apps. This service downloads the associations between Android "
+            "apps and the corresponding websites. Thus, the android "

[engedy, 2017/02/21 12:39:18]

nit: Android

[Ramin Halavati, 2017/02/21 13:12:02]

Done.

+            "credentials can be used while browsing the web. "
+          trigger: "On startup."

[engedy, 2017/02/21 12:39:18]

Yes, it's most often on start-up, but there are also periodic updates and some
edge cases, so I would write `Periodically in the background.`.

[Ramin Halavati, 2017/02/21 13:12:02]

Done.

+          data:
+            "List of Android apps the user has credentials for. The passwords "
+            "and usernames aren't sent."
+          destination: GOOGLE_OWNED_SERVICE
+        }
+        policy {
+          cookies_allowed: false
+          setting:
+            "Users can enable or disable this feature either by stoping "
+            "syncing passwords to Google (via unchecking 'Passwords' in "
+            "Chrome's settings under 'Sign In', 'advanced sync settings') or "

[engedy, 2017/02/21 12:39:18]

nit: Advanced

[Ramin Halavati, 2017/02/21 13:12:02]

Done.

+            "by introducing a custom passphrase to disable this service. The "
+            "feature is enabled by default."
+          policy {
+            SyncDisabled {
+              policy_options {mode: MANDATORY}
+              value: True
+            }
+          }
+        })");
+  fetcher_ = net::URLFetcher::Create(BuildQueryURL(), net::URLFetcher::POST,
+                                     this, traffic_annotation);
   fetcher_->SetRequestContext(request_context_getter_.get());
   fetcher_->SetUploadData("application/x-protobuf", PreparePayload());
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES |
                          net::LOAD_DO_NOT_SEND_COOKIES |
                          net::LOAD_DO_NOT_SEND_AUTH_DATA |
                          net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE);
   fetcher_->SetAutomaticallyRetryOn5xx(false);
   fetcher_->SetAutomaticallyRetryOnNetworkChanges(0);
   fetcher_->Start();
 }
@@ skipping 104 matching lines @@
       ReportStatistics(AFFILIATION_FETCH_RESULT_MALFORMED, nullptr);
       delegate_->OnMalformedResponse();
     }
   } else {
     ReportStatistics(AFFILIATION_FETCH_RESULT_FAILURE, fetcher_.get());
     delegate_->OnFetchFailed();
   }
 }
 
 }  // namespace password_manager