Network traffic annotation added to affiliation_fetcher.

components/password_manager/core/browser/affiliation_fetcher.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/affiliation_fetcher.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/metrics/histogram_macros.h"
 #include "base/metrics/sparse_histogram.h"
 #include "components/password_manager/core/browser/affiliation_api.pb.h"
 #include "components/password_manager/core/browser/affiliation_utils.h"
 #include "components/password_manager/core/browser/test_affiliation_fetcher_factory.h"
 #include "google_apis/google_api_keys.h"
 #include "net/base/load_flags.h"
 #include "net/base/url_util.h"
 #include "net/http/http_status_code.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "url/gurl.h"
 
 namespace password_manager {
 
 namespace {
 
 // Enumeration listing the possible outcomes of fetching affiliation information
 // from the Affiliation API. This is used in UMA histograms, so do not change
@@ skipping 55 matching lines @@
 
 // static
 void AffiliationFetcher::SetFactoryForTesting(
     TestAffiliationFetcherFactory* factory) {
   g_testing_factory = factory;
 }
 
 void AffiliationFetcher::StartRequest() {
   DCHECK(!fetcher_);
 
-  fetcher_ =
-      net::URLFetcher::Create(BuildQueryURL(), net::URLFetcher::POST, this);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(

[vasilii, 2017/02/21 10:37:58]

android_affiliation

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+        semantics {
+          sender: "..."

[vasilii, 2017/02/21 10:37:58]

affiliation_fetcher

[Ramin Halavati, 2017/02/21 11:59:10]

Done. Can it be "Android Affiliation Fetcher"?

[vasilii, 2017/02/21 12:03:20]

I think it's confusing because it's running on desktop (and on Android). Maybe
"Android credentials affiliation fetcher"?

[engedy, 2017/02/21 12:39:18]

+1.

[Ramin Halavati, 2017/02/21 13:12:02]

Done.

+          description: "..."

[vasilii, 2017/02/21 10:37:58]

For the users syncing their passwords to Google without a custom passphrase
their password storage may contain credentials for Android apps. The service
downloads the associations between the Android apps and the corresponding
websites. Thus, the android credentials can be used while browsing the web. 

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+          trigger: "..."

[vasilii, 2017/02/21 10:37:58]

On startup.

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+          data: "..."

[vasilii, 2017/02/21 10:37:58]

List of the Android apps the user has credentials for. The passwords and
usernames aren't sent.

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[vasilii, 2017/02/21 10:37:58]

GOOGLE_OWNED_SERVICE

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+        }
+        policy {
+          cookies_allowed: false
+          setting: "..."

[vasilii, 2017/02/21 10:37:58]

One can either stop syncing the passwords to Google or introduce a custom
passphrase to disable the service. 

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+          policy {
+            [POLICY_NAME] {

[vasilii, 2017/02/21 10:37:58]

SyncDisabled

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}

[vasilii, 2017/02/21 10:37:58]

MANDATORY

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+              value: ...

[vasilii, 2017/02/21 10:37:58]

True

[Ramin Halavati, 2017/02/21 11:59:10]

Done.

+            }
+          }
+          policy_exception_justification: "..."
+        })");
+  fetcher_ = net::URLFetcher::Create(BuildQueryURL(), net::URLFetcher::POST,
+                                     this, traffic_annotation);
   fetcher_->SetRequestContext(request_context_getter_.get());
   fetcher_->SetUploadData("application/x-protobuf", PreparePayload());
   fetcher_->SetLoadFlags(net::LOAD_DO_NOT_SAVE_COOKIES |
                          net::LOAD_DO_NOT_SEND_COOKIES |
                          net::LOAD_DO_NOT_SEND_AUTH_DATA |
                          net::LOAD_BYPASS_CACHE | net::LOAD_DISABLE_CACHE);
   fetcher_->SetAutomaticallyRetryOn5xx(false);
   fetcher_->SetAutomaticallyRetryOnNetworkChanges(0);
   fetcher_->Start();
 }
@@ skipping 104 matching lines @@
       ReportStatistics(AFFILIATION_FETCH_RESULT_MALFORMED, nullptr);
       delegate_->OnMalformedResponse();
     }
   } else {
     ReportStatistics(AFFILIATION_FETCH_RESULT_FAILURE, fetcher_.get());
     delegate_->OnFetchFailed();
   }
 }
 
 }  // namespace password_manager