Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: remoting/protocol/webrtc_transport.cc

Issue 2710483002: Actually pass the stereo=1 parameter to WebRTC for receiving audio (Closed)
Patch Set: err -> parse_error, no braces Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/connection_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/webrtc_transport.cc
diff --git a/remoting/protocol/webrtc_transport.cc b/remoting/protocol/webrtc_transport.cc
index c9c88c4e5a4716067ddbc4cc91bdbdc07e46c639..dcbbb8c8dddc17a2e692351712a24fc66bb97e75 100644
--- a/remoting/protocol/webrtc_transport.cc
+++ b/remoting/protocol/webrtc_transport.cc
@@ -472,6 +472,15 @@ void WebrtcTransport::OnLocalSessionDescriptionCreated(
SdpMessage sdp_message(description_sdp);
UpdateCodecParameters(&sdp_message, /*incoming=*/false);
description_sdp = sdp_message.ToString();
+ webrtc::SdpParseError parse_error;
+ description.reset(webrtc::CreateSessionDescription(
+ description->type(), description_sdp, &parse_error));
+ if (!description) {
+ LOG(ERROR) << "Failed to parse the session description: "
+ << parse_error.description << " line: " << parse_error.line;
+ Close(CHANNEL_CONNECTION_ERROR);
+ return;
+ }
// Format and send the session description to the peer.
std::unique_ptr<XmlElement> transport_info(
« no previous file with comments | « remoting/protocol/connection_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698