Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2832)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2710473003: 📰 Ensure NTP Tiles keep tracking recent data (Closed)
Patch Set: Add OWNERS file for new test folder Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 1994220097dc7f42a9727d9eac12361fbee15b48..7d55cd4388f38ba98e1c1b32c6f91da5bdc746ad 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -230,8 +230,8 @@ public void onDestroy() {
mTileGridLayout = (TileGridLayout) mNewTabPageLayout.findViewById(R.id.tile_grid_layout);
mTileGridLayout.setMaxRows(getMaxTileRows(searchProviderHasLogo));
- mTileGroup = new TileGroup(
- mManager, mContextMenuManager, mTileGroupDelegate, /* observer = */ this);
+ mTileGroup = new TileGroup(mActivity, mManager, mContextMenuManager, mTileGroupDelegate,
+ /* observer = */ this, getTileTitleLines());
mSearchProviderLogoView =
(LogoView) mNewTabPageLayout.findViewById(R.id.search_provider_logo);
@@ -244,7 +244,6 @@ public void onDestroy() {
mNewTabPageLayout.addOnLayoutChangeListener(this);
setSearchProviderHasLogo(searchProviderHasLogo);
- mPendingLoadTasks++;
mTileGroup.startObserving(getMaxTileRows(searchProviderHasLogo) * MAX_TILE_COLUMNS);
// Set up snippets
@@ -855,7 +854,7 @@ public ContextMenuManager getContextMenuManager() {
@Override
public void onTileDataChanged() {
- mTileGroup.renderTileViews(mTileGridLayout, !mLoadHasCompleted, getTileTitleLines());
+ mTileGroup.renderTileViews(mTileGridLayout, !mLoadHasCompleted);
mSnapshotTileGridChanged = true;
// The page contents are initially hidden; otherwise they'll be drawn centered on the page
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/suggestions/Tile.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698