Issue 271045: Fix for the bookmark_bar which got ignored in my earlier...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 271045: Fix for the bookmark_bar which got ignored in my earlier... (Closed)

Created:
11 years, 2 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit), Nico

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix for the bookmark_bar which got ignored in my earlier theming CL (28613). This fixes up drawing so the themes line up correctly. BUG=24481, 24484 TEST=None

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bar_toolbar_view.mm	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

Didn't you submit this with gcl / git cl? They should've closed the issue automatically ...

11 years, 2 months ago (2009-10-15 02:41:45 UTC) #2

John Grabowski

Close is a distinct POST request to rietveld. Just as codereview sometimes flakes in general, ...

11 years, 2 months ago (2009-10-15 02:49:41 UTC) #3

dmaclach1

11 years, 2 months ago (2009-10-15 04:23:01 UTC) #4

I've had a couple of them flake. I'll take care of them manually in =20
the future.

Cheers,
Dave

On Oct 14, 2009, at 7:49 PM, John Grabowski wrote:

> Close is a distinct POST request to rietveld.  Just as codereview =20
> sometimes flakes in general, the  close POST sometimes flakes.
>
> jrg
>
>
> On Wed, Oct 14, 2009 at 7:41 PM, <thakis@chromium.org> wrote:
> Didn't you submit this with gcl / git cl? They should've closed the =20=

> issue
> automatically after submission=85anyway, closing this manually.
>
>
> http://codereview.chromium.org/271045
>

Expand Messages | Collapse Messages