Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Side by Side Diff: Source/core/rendering/RenderLayer.h

Issue 27104002: Fix ASSERT failure in RenderGeometryMap. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: +test Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderGeometryMap.cpp ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 ASSERT(isStackingContainer() || !m_negZOrderList); 242 ASSERT(isStackingContainer() || !m_negZOrderList);
243 return m_negZOrderList.get(); 243 return m_negZOrderList.get();
244 } 244 }
245 245
246 void dirtyNormalFlowList(); 246 void dirtyNormalFlowList();
247 Vector<RenderLayer*>* normalFlowList() const { ASSERT(!m_normalFlowListDirty ); return m_normalFlowList.get(); } 247 Vector<RenderLayer*>* normalFlowList() const { ASSERT(!m_normalFlowListDirty ); return m_normalFlowList.get(); }
248 248
249 // Update our normal and z-index lists. 249 // Update our normal and z-index lists.
250 void updateLayerListsIfNeeded(); 250 void updateLayerListsIfNeeded();
251 251
252 bool subtreeIsInvisible() const { return !hasVisibleContent() && !hasVisible Descendant(); }
253
252 // FIXME: We should ASSERT(!m_visibleContentStatusDirty) here, but see https ://bugs.webkit.org/show_bug.cgi?id=71044 254 // FIXME: We should ASSERT(!m_visibleContentStatusDirty) here, but see https ://bugs.webkit.org/show_bug.cgi?id=71044
253 // ditto for hasVisibleDescendant(), see https://bugs.webkit.org/show_bug.cg i?id=71277 255 // ditto for hasVisibleDescendant(), see https://bugs.webkit.org/show_bug.cg i?id=71277
254 bool hasVisibleContent() const { return m_hasVisibleContent; } 256 bool hasVisibleContent() const { return m_hasVisibleContent; }
255 bool hasVisibleDescendant() const { return m_hasVisibleDescendant; } 257 bool hasVisibleDescendant() const { return m_hasVisibleDescendant; }
256 258
257 void setHasVisibleContent(); 259 void setHasVisibleContent();
258 void dirtyVisibleContentStatus(); 260 void dirtyVisibleContentStatus();
259 261
260 bool hasBoxDecorationsOrBackground() const; 262 bool hasBoxDecorationsOrBackground() const;
261 bool hasVisibleBoxDecorations() const; 263 bool hasVisibleBoxDecorations() const;
(...skipping 688 matching lines...) Expand 10 before | Expand all | Expand 10 after
950 952
951 } // namespace WebCore 953 } // namespace WebCore
952 954
953 #ifndef NDEBUG 955 #ifndef NDEBUG
954 // Outside the WebCore namespace for ease of invocation from gdb. 956 // Outside the WebCore namespace for ease of invocation from gdb.
955 void showLayerTree(const WebCore::RenderLayer*); 957 void showLayerTree(const WebCore::RenderLayer*);
956 void showLayerTree(const WebCore::RenderObject*); 958 void showLayerTree(const WebCore::RenderObject*);
957 #endif 959 #endif
958 960
959 #endif // RenderLayer_h 961 #endif // RenderLayer_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderGeometryMap.cpp ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698