Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: pkg/analyzer/lib/src/dart/ast/ast_factory.dart

Issue 2710393002: Revert "Add NormalFormalParameter.covariantKeyword setter and factory parameter." (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/dart/ast/ast.dart ('k') | pkg/analyzer/lib/src/dart/ast/utilities.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/ast/ast_factory.dart
diff --git a/pkg/analyzer/lib/src/dart/ast/ast_factory.dart b/pkg/analyzer/lib/src/dart/ast/ast_factory.dart
index 03ed9dfcb9cd24929121c77e42caa9966d3b6d2f..482ae0161c3fd87e9797c5a9f3904c25ff169027 100644
--- a/pkg/analyzer/lib/src/dart/ast/ast_factory.dart
+++ b/pkg/analyzer/lib/src/dart/ast/ast_factory.dart
@@ -366,7 +366,6 @@ class AstFactoryImpl extends AstFactory {
FieldFormalParameter fieldFormalParameter(
Comment comment,
List<Annotation> metadata,
- Token covariantKeyword,
Token keyword,
TypeAnnotation type,
Token thisKeyword,
@@ -374,8 +373,8 @@ class AstFactoryImpl extends AstFactory {
SimpleIdentifier identifier,
TypeParameterList typeParameters,
FormalParameterList parameters) =>
- new FieldFormalParameterImpl(comment, metadata, covariantKeyword, keyword,
- type, thisKeyword, period, identifier, typeParameters, parameters);
+ new FieldFormalParameterImpl(comment, metadata, keyword, type,
+ thisKeyword, period, identifier, typeParameters, parameters);
@override
ForEachStatement forEachStatementWithDeclaration(
@@ -496,14 +495,13 @@ class AstFactoryImpl extends AstFactory {
FunctionTypedFormalParameter functionTypedFormalParameter(
Comment comment,
List<Annotation> metadata,
- Token covariantKeyword,
TypeAnnotation returnType,
SimpleIdentifier identifier,
TypeParameterList typeParameters,
FormalParameterList parameters,
{Token question: null}) =>
- new FunctionTypedFormalParameterImpl(comment, metadata, covariantKeyword,
- returnType, identifier, typeParameters, parameters, question);
+ new FunctionTypedFormalParameterImpl(comment, metadata, returnType,
+ identifier, typeParameters, parameters, question);
@override
GenericFunctionType genericFunctionType(
@@ -776,12 +774,11 @@ class AstFactoryImpl extends AstFactory {
SimpleFormalParameter simpleFormalParameter(
Comment comment,
List<Annotation> metadata,
- Token covariantKeyword,
Token keyword,
TypeAnnotation type,
SimpleIdentifier identifier) =>
new SimpleFormalParameterImpl(
- comment, metadata, covariantKeyword, keyword, type, identifier);
+ comment, metadata, keyword, type, identifier);
@override
SimpleIdentifier simpleIdentifier(Token token, {bool isDeclaration: false}) {
« no previous file with comments | « pkg/analyzer/lib/src/dart/ast/ast.dart ('k') | pkg/analyzer/lib/src/dart/ast/utilities.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698