Issue 2710393002: Revert "Add NormalFormalParameter.covariantKeyword setter and factory parameter."

Issue 2710393002: Revert "Add NormalFormalParameter.covariantKeyword setter and factory parameter." (Closed)

Created:
3 years, 10 months ago by scheglov

Modified:
3 years, 10 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Add NormalFormalParameter.covariantKeyword setter and factory parameter." This reverts commit 57b78f422ea468c9a9775b658448bf707561b0f7. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ddddb2c50d2845ee5e479a82717cef4c76e5b336

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -89 lines)			Patch
M	pkg/analyzer/lib/dart/ast/ast.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	pkg/analyzer/lib/dart/ast/ast_factory.dart	View	7 chunks	+15 lines, -31 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/ast/ast.dart	View	5 chunks	+6 lines, -13 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/ast/ast_factory.dart	View	4 chunks	+5 lines, -8 lines	0 comments	Download
M	pkg/analyzer/lib/src/dart/ast/utilities.dart	View	6 chunks	+0 lines, -6 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	5 chunks	+24 lines, -17 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/testing/ast_test_factory.dart	View	3 chunks	+1 line, -3 lines	0 comments	Download
M	pkg/analyzer/test/src/dart/ast/utilities_test.dart	View	4 chunks	+0 lines, -4 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as ddddb2c50d2845ee5e479a82717cef4c76e5b336 (presubmit successful).

3 years, 10 months ago (2017-02-24 05:22:09 UTC) #3

Message was sent while issue was closed.

lgtm