Fix VM crash when parsing a non-existing redirecting constructor

runtime/vm/parser.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/parser.h"
 #include "vm/flags.h"
 
 #ifndef DART_PRECOMPILED_RUNTIME
 
 #include "lib/invocation_mirror.h"
@@ skipping 3103 matching lines @@
   arguments->Add(implicit_argument);
 
   receiver->set_invisible(true);
   ParseActualParameters(arguments, kAllowConst);
   receiver->set_invisible(false);
   // Resolve the constructor.
   const Function& redirect_ctor =
       Function::ZoneHandle(Z, cls.LookupConstructor(ctor_name));
   if (redirect_ctor.IsNull()) {
     if (cls.LookupFactory(ctor_name) != Function::null()) {
-      ReportError(
-          call_pos, "redirection constructor '%s' must not be a factory",
-          String::Handle(Z, redirect_ctor.UserVisibleName()).ToCString());
+      ReportError(call_pos,
+                  "redirection constructor '%s' must not be a factory",
+                  ctor_name.ToCString());

[hausner, 2017/02/26 18:30:27]

I think you want to use a user-visible name here, not a decorated one. For
example, the unnamed constructor for class C should be reported as "C", not
"C.". See String::ScrubName().

[Florian Schneider, 2017/02/27 18:14:50]

Good point. I'll change it to use ScrubName instead.

     }
-    ReportError(call_pos, "constructor '%s' not found",
-                String::Handle(Z, redirect_ctor.UserVisibleName()).ToCString());
+    ReportError(call_pos, "constructor '%s' not found", ctor_name.ToCString());
   }
   if (current_function().is_const() && !redirect_ctor.is_const()) {
     ReportError(call_pos, "redirection constructor '%s' must be const",
                 String::Handle(Z, redirect_ctor.UserVisibleName()).ToCString());
   }
   String& error_message = String::Handle(Z);
   if (!redirect_ctor.AreValidArguments(arguments->length(), arguments->names(),
                                        &error_message)) {
     ReportError(call_pos, "invalid arguments passed to constructor '%s': %s",
                 String::Handle(Z, redirect_ctor.UserVisibleName()).ToCString(),
@@ skipping 11927 matching lines @@
     const ArgumentListNode& function_args,
     const LocalVariable* temp_for_last_arg,
     bool is_super_invocation) {
   UNREACHABLE();
   return NULL;
 }
 
 }  // namespace dart
 
 #endif  // DART_PRECOMPILED_RUNTIME