Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2710363002: Fix VM crash when parsing a non-existing redirecting constructor (Closed)

Created:
3 years, 10 months ago by Florian Schneider
Modified:
3 years, 9 months ago
Reviewers:
rmacnak, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix VM crash when parsing a non-existing redirecting constructor Fixes #28217. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/864166a7583f6862dcd4346f9338ad326a5c2408

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -5 lines) Patch
M runtime/vm/parser.cc View 1 chunk +4 lines, -5 lines 2 comments Download
A tests/language/regress_28217_test.dart View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Florian Schneider
3 years, 10 months ago (2017-02-23 23:56:52 UTC) #2
rmacnak
LGTM
3 years, 10 months ago (2017-02-24 03:23:25 UTC) #3
Florian Schneider
Committed patchset #1 (id:1) manually as 864166a7583f6862dcd4346f9338ad326a5c2408 (presubmit successful).
3 years, 10 months ago (2017-02-24 18:26:38 UTC) #5
hausner
DBC https://codereview.chromium.org/2710363002/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/2710363002/diff/1/runtime/vm/parser.cc#newcode3126 runtime/vm/parser.cc:3126: ctor_name.ToCString()); I think you want to use a ...
3 years, 9 months ago (2017-02-26 18:30:27 UTC) #7
Florian Schneider
3 years, 9 months ago (2017-02-27 18:14:51 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/2710363002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2710363002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:3126: ctor_name.ToCString());
On 2017/02/26 18:30:27, hausner wrote:
> I think you want to use a user-visible name here, not a decorated one. For
> example, the unnamed constructor for class C should be reported as "C", not
> "C.". See String::ScrubName().

Good point. I'll change it to use ScrubName instead.

Powered by Google App Engine
This is Rietveld 408576698