Update Robolectric to 3.2.2

components/variations/android/junit/src/org/chromium/components/variations/firstrun/VariationsSeedFetcherTest.java

Index: components/variations/android/junit/src/org/chromium/components/variations/firstrun/VariationsSeedFetcherTest.java
diff --git a/components/variations/android/junit/src/org/chromium/components/variations/firstrun/VariationsSeedFetcherTest.java b/components/variations/android/junit/src/org/chromium/components/variations/firstrun/VariationsSeedFetcherTest.java
index 9c725103ddb9e6a058187904d2b46a9aa073cac0..1835e1ea53347109705da60f0c910198870c1baf 100644
--- a/components/variations/android/junit/src/org/chromium/components/variations/firstrun/VariationsSeedFetcherTest.java
+++ b/components/variations/android/junit/src/org/chromium/components/variations/firstrun/VariationsSeedFetcherTest.java
@@ -24,6 +24,7 @@ import org.junit.After;
 import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
+import org.robolectric.RuntimeEnvironment;
 import org.robolectric.annotation.Config;
 
 import org.chromium.base.ContextUtils;
@@ -46,6 +47,7 @@ public class VariationsSeedFetcherTest {
 
     @Before
     public void setUp() throws IOException {
+        ContextUtils.initApplicationContextForTests(RuntimeEnvironment.application);

[mikecase (-- gone --), 2017/03/07 20:29:41]

Adding this fixed some errors when running the test. Unsure if this is correct
though. Would appreciate if someone more familiar with the code confirmed

[jwd, 2017/03/08 22:44:33]

What does this line do? The robolectric doc on RuntimeEnvironment.application
doesn't describe it
http://robolectric.org/javadoc/3.2/org/robolectric/RuntimeEnvironment.html#ap....

What were the errors you were getting without it?

[mikecase (-- gone --), 2017/03/09 01:50:28]

I think RuntimeEnvironment.application is just how you get the application
Context within a Robolectric test.

The error I get without this line is....

[ RUN      ]
org.chromium.components.variations.firstrun.VariationsSeedFetcherTest.testFetchSeed_badResponse
java.lang.ExceptionInInitializerError
	at org.chromium.base.ContextUtils.getAppSharedPreferences(ContextUtils.java:91)
	at
org.chromium.components.variations.firstrun.VariationsSeedFetcherTest.setUp(VariationsSeedFetcherTest.java:57)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at
org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at
org.robolectric.RobolectricTestRunner$2.evaluate(RobolectricTestRunner.java:316)
	at
org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:236)
	at
org.robolectric.RobolectricTestRunner.runChild(RobolectricTestRunner.java:41)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at
org.robolectric.RobolectricTestRunner$1.evaluate(RobolectricTestRunner.java:176)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at
org.chromium.testing.local.GtestComputer$GtestSuiteRunner.run(GtestComputer.java:46)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at org.chromium.testing.local.JunitTestMain.main(JunitTestMain.java:105)
Caused by: java.lang.NullPointerException
	at
android.preference.PreferenceManager.getDefaultSharedPreferencesName(PreferenceManager.java:498)
	at
android.preference.PreferenceManager.getDefaultSharedPreferences(PreferenceManager.java:487)
	at
org.chromium.base.ContextUtils.fetchAppSharedPreferences(ContextUtils.java:80)
	at org.chromium.base.ContextUtils.access$000(ContextUtils.java:19)
	at org.chromium.base.ContextUtils$Holder.<clinit>(ContextUtils.java:28)
	at org.chromium.base.ContextUtils.getAppSharedPreferences(ContextUtils.java:91)
	at
org.chromium.components.variations.firstrun.VariationsSeedFetcherTest.setUp(VariationsSeedFetcherTest.java:57)
	... 27 more

[jwd, 2017/03/09 15:16:31]

Ok, seems fine to add it. The test shouldn't be affected. I don't understand
what's changed between 3.0 and 3.2 that broke this though.

         // Pretend we are not on the UI thread, since the class we are testing is supposed to run
         // only on a background thread.
         ThreadUtils.setUiThread(mock(Looper.class));