third_party/guava/lib/guava-18.0.jar.sha1 - Issue 2710343003: Update Robolectric to 3.2.2

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/guava/lib/guava-18.0.jar.sha1

Issue 2710343003: Update Robolectric to 3.2.2 (Closed)

Patch Set: Update Robolectric to 3.2 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java ('K') | « third_party/guava/README.chromium ('k') | third_party/guava/lib/guava-20.0.jar.sha1 » ('j') | third_party/robolectric/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 cce0823396aa693798f8882e64213b1772032b09
jbudorick 2017/02/27 02:16:44 Will the jars that people have previously download Will the jars that people have previously downloaded get removed? If not, will we at least mention something along the lines of what gclient does when a repo is no longer used ("xyz is no longer necessary, it's recommended that you delete it" or something along those lines)? mikecase (-- gone --) 2017/02/27 16:21:06 No, I dont think jars that people have will get re Show quoted text On 2017/02/27 at 02:16:44, jbudorick is ooo until monday wrote: > Will the jars that people have previously downloaded get removed? If not, will we at least mention something along the lines of what gclient does when a repo is no longer used ("xyz is no longer necessary, it's recommended that you delete it" or something along those lines)? No, I dont think jars that people have will get removed. Un mikecase (-- gone --) 2017/02/27 18:03:26 What I could do, is add the JARs I need explicitly Show quoted text On 2017/02/27 at 16:21:06, mikecase wrote: > On 2017/02/27 at 02:16:44, jbudorick is ooo until monday wrote: > > Will the jars that people have previously downloaded get removed? If not, will we at least mention something along the lines of what gclient does when a repo is no longer used ("xyz is no longer necessary, it's recommended that you delete it" or something along those lines)? > > No, I dont think jars that people have will get removed. Un What I could do, is add the JARs I need explicitly named to the .gitignore (instead of ignoring guava/lib/*.jar, I would ignore guava/lib/guava-20.0.jar). So at least people would see the files they no longer need and can delete them.
OLD	NEW