chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java - Issue 2710323003: 🏠 Close the bottom sheet when opening link in incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

Issue 2710323003: 🏠 Close the bottom sheet when opening link in incognito (Closed)

Patch Set: Properly make ContentSuggestionsActivity compile Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContentSuggestionsActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

index bee3f48a4b24b71f4f1e22a9d119c450af3bf521..1aa46498fd356645fd5bfc7fa5208878379b1559 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java

@@ -2160,7 +2160,7 @@ protected void loadUrl(String url, int transition) {

// If the bottom sheet exists, route the navigation through it instead of the tab.

if (mBottomSheet != null) {

- mBottomSheet.loadUrl(loadUrlParams);

+ mBottomSheet.loadUrl(loadUrlParams, /* incognito = */ false);

} else {

currentTab.loadUrl(loadUrlParams);

}