third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js - Issue 2710203003: [DevTools] show inlined shortcuts for go to location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

Issue 2710203003: [DevTools] show inlined shortcuts for go to location (Closed)

Patch Set: addressed comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

index 946b79db4e5214510523de34f54807075bbcc6d8..b5261b975d818c4e03d0e1cf67077e3c4eeb916d 100644

--- a/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPopoverHelper.js

@@ -95,12 +95,6 @@ ObjectUI.ObjectPopoverHelper = class extends UI.PopoverHelper {

var rawLocation = response.location;

var linkContainer = title.createChild('div', 'function-title-link-container');

- if (rawLocation && Runtime.experiments.isEnabled('continueToFirstInvocation')) {

- var sectionToolbar = new UI.Toolbar('function-location-step-into', linkContainer);

- var stepInto = new UI.ToolbarButton(Common.UIString('Continue to first invocation'), 'largeicon-step-in');

- stepInto.addEventListener(UI.ToolbarButton.Events.Click, () => rawLocation.continueToLocation());

- sectionToolbar.appendToolbarItem(stepInto);

- }

var sourceURL = rawLocation && rawLocation.script() ? rawLocation.script().sourceURL : null;

if (rawLocation && sourceURL)

linkContainer.appendChild(this._lazyLinkifier().linkifyRawLocation(rawLocation, sourceURL));