Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 27102: Fixing 8010: Missing options from Options dlg.... (Closed)

Created:
9 years, 5 months ago by Finnur
Modified:
7 years, 1 month ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fixing 8010: Missing options from Options dlg. This should also fix the hang in the interactive_ui_tests. The problem is in a one line change in view.cc where we return early from a Layout call. BUG=8010 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/views/view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
9 years, 5 months ago (2009-02-24 21:41:23 UTC) #1
Ben Goodger (Google)
9 years, 5 months ago (2009-02-24 21:43:45 UTC) #2
OK - can you add a comment saying that we think we should return here since the
layout manager should be handling things but it causes regressions?

Powered by Google App Engine
This is Rietveld 408576698