Issue 2710193004: Fix SummaryDataStore to support using a ResourceProvider instead of dart:io

Issue 2710193004: Fix SummaryDataStore to support using a ResourceProvider instead of dart:io (Closed)

Created:
3 years, 10 months ago by Jacob

Modified:
3 years, 10 months ago

Reviewers:
scheglov, Brian Wilkerson

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix SummaryDataStore to support using a ResourceProvider instead of dart:io This code broke running the Analyzer under Dart2JS. BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/7cdf5d7f7b542b0393b22b5043e32ae648f3db30

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -13 lines)			Patch
M	pkg/analyzer/lib/src/context/builder.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/dart/sdk/sdk.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/summary/package_bundle_reader.dart	View		3 chunks	+12 lines, -5 lines	0 comments	Download
M	pkg/analyzer/lib/src/summary/summary_sdk.dart	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 7 (3 generated)

Jacob

This active dart:io dependency broke running the analyzer under Dart2JS

3 years, 10 months ago (2017-02-23 18:03:51 UTC) #2

scheglov

lgtm Ideally though SummaryDataStore should not read any files at all. It should be just ...

3 years, 10 months ago (2017-02-23 18:55:29 UTC) #5

Jacob

3 years, 10 months ago (2017-02-23 19:03:44 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
7cdf5d7f7b542b0393b22b5043e32ae648f3db30 (presubmit successful).