Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: pylib/gyp/generator/scons.py

Issue 271019: Adding cross-compile ability to the make build (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/msvs.py ('k') | pylib/gyp/generator/xcode.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/scons.py
===================================================================
--- pylib/gyp/generator/scons.py (revision 706)
+++ pylib/gyp/generator/scons.py (working copy)
@@ -902,7 +902,7 @@
"""Returns the .scons file name for the specified target.
"""
if build_file is None:
- build_file, target = gyp.common.BuildFileAndTarget('', target)[:2]
+ build_file, target = gyp.common.ParseQualifiedTarget(target)[:2]
output_file = os.path.join(os.path.dirname(build_file),
target + output_suffix + '.scons')
return output_file
@@ -925,6 +925,10 @@
for qualified_target in target_list:
spec = target_dicts[qualified_target]
+ if spec['toolset'] != 'target':
+ raise Exception(
+ 'Multiple toolsets not supported in scons build (target %s)' %
+ qualified_target)
scons_target = SCons.Target(spec)
if scons_target.is_ignored:
continue
@@ -936,7 +940,7 @@
spec['default_configuration'] != 'Default'):
default_configuration = spec['default_configuration']
- build_file, target = gyp.common.BuildFileAndTarget('', qualified_target)[:2]
+ build_file, target = gyp.common.ParseQualifiedTarget(qualified_target)[:2]
output_file = TargetFilename(target, build_file, options.suffix)
if options.generator_output:
output_file = output_path(output_file)
@@ -981,7 +985,7 @@
scons_target = SCons.Target(target_dicts[t])
if scons_target.is_ignored:
continue
- bf, target = gyp.common.BuildFileAndTarget('', t)[:2]
+ bf, target = gyp.common.ParseQualifiedTarget(t)[:2]
target_filename = TargetFilename(target, bf, options.suffix)
tpath = gyp.common.RelativePath(target_filename, output_dir)
sconscript_files[target] = tpath
« no previous file with comments | « pylib/gyp/generator/msvs.py ('k') | pylib/gyp/generator/xcode.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698