components/tracing/common/process_metrics_memory_dump_provider.h - Issue 2710163002: Implement basic support for Windows module emission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/tracing/common/process_metrics_memory_dump_provider.h

Issue 2710163002: Implement basic support for Windows module emission. (Closed)

Patch Set: Comments from etienne. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/tracing/common/process_metrics_memory_dump_provider.h

diff --git a/components/tracing/common/process_metrics_memory_dump_provider.h b/components/tracing/common/process_metrics_memory_dump_provider.h

index ec1a9d66ab52115d66bfe504ce4e270969c8ce36..57623d7b93ab36ba9c9ce9cc6de45eec0072f78e 100644

--- a/components/tracing/common/process_metrics_memory_dump_provider.h

+++ b/components/tracing/common/process_metrics_memory_dump_provider.h

@@ -49,6 +49,10 @@ class TRACING_EXPORT ProcessMetricsMemoryDumpProvider

FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,

NoDuplicateRegions);

#endif // defined(OS_MACOSX)

+#if defined(OS_WIN)

+ FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,

+ TestWinModuleReading);

+#endif // defined(OS_WIN)

ProcessMetricsMemoryDumpProvider(base::ProcessId process);