Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/tracing/common/process_metrics_memory_dump_provider.h

Issue 2710163002: Implement basic support for Windows module emission. (Closed)
Patch Set: Respond to comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/tracing/common/process_metrics_memory_dump_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/common/process_metrics_memory_dump_provider.h
diff --git a/components/tracing/common/process_metrics_memory_dump_provider.h b/components/tracing/common/process_metrics_memory_dump_provider.h
index ec1a9d66ab52115d66bfe504ce4e270969c8ce36..6534f18bf43d8f0afb04e4e8ee02f9bffaa06223 100644
--- a/components/tracing/common/process_metrics_memory_dump_provider.h
+++ b/components/tracing/common/process_metrics_memory_dump_provider.h
@@ -48,7 +48,10 @@ class TRACING_EXPORT ProcessMetricsMemoryDumpProvider
TestMachOReading);
FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,
NoDuplicateRegions);
-#endif // defined(OS_MACOSX)
+#elif defined(OS_WIN)
+ FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,
+ TestWinModuleReading);
+#endif
ProcessMetricsMemoryDumpProvider(base::ProcessId process);
« no previous file with comments | « no previous file | components/tracing/common/process_metrics_memory_dump_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698