Implement basic support for Windows module emission.

components/tracing/common/process_metrics_memory_dump_provider.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_TRACING_COMMON_PROCESS_MEMORY_METRICS_DUMP_PROVIDER_H_
 #define COMPONENTS_TRACING_COMMON_PROCESS_MEMORY_METRICS_DUMP_PROVIDER_H_
 
 #include <memory>
 
 #include "base/files/scoped_file.h"
@@ skipping 30 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,
                            ParseProcSmaps);
   FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest, DumpRSS);
   FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,
                            TestPollFastMemoryTotal);
 #if defined(OS_MACOSX)
   FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,
                            TestMachOReading);
   FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,
                            NoDuplicateRegions);
 #endif  // defined(OS_MACOSX)

[awong, 2017/02/23 22:05:44]

#elif?

[Wez, 2017/02/23 23:35:03]

Or just rename the platform-specific module reading tests to
TestPlatformRegionDump or something equally generic, so we can unconditionally
friend that.

+#if defined(OS_WIN)
+  FRIEND_TEST_ALL_PREFIXES(ProcessMetricsMemoryDumpProviderTest,
+                           TestWinModuleReading);
+#endif  // defined(OS_WIN)
 
   ProcessMetricsMemoryDumpProvider(base::ProcessId process);
 
   bool DumpProcessTotals(const base::trace_event::MemoryDumpArgs& args,
                          base::trace_event::ProcessMemoryDump* pmd);
   bool DumpProcessMemoryMaps(const base::trace_event::MemoryDumpArgs& args,
                              base::trace_event::ProcessMemoryDump* pmd);
 
   static uint64_t rss_bytes_for_testing;
 
@@ skipping 11 matching lines @@
   // older than http://bit.ly/reset_rss or only on child processes if yama LSM
   // sandbox is enabled.
   bool is_rss_peak_resettable_;
 
   DISALLOW_COPY_AND_ASSIGN(ProcessMetricsMemoryDumpProvider);
 };
 
 }  // namespace tracing
 
 #endif  // COMPONENTS_TRACING_COMMON_PROCESS_MEMORY_METRICS_DUMP_PROVIDER_H_