Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm

Issue 2710103003: cocoa: darken toolbar buttons in Increase Contrast mode (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm b/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
index e5065fcaa490ef6da807bcaa4e71580a839893e5..f2b15d1221ac83681d07573acdf4caee0e73b253 100644
--- a/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
+++ b/chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm
@@ -9,6 +9,7 @@
#import "chrome/browser/ui/cocoa/themed_window.h"
#import "chrome/browser/ui/cocoa/view_id_util.h"
#include "ui/base/material_design/material_design_controller.h"
+#include "ui/base/theme_provider.h"
#include "ui/gfx/color_palette.h"
@interface AppToolbarButton ()
@@ -50,9 +51,13 @@ - (void)commonInit {
}
- (SkColor)vectorIconColor:(BOOL)themeIsDark {
+ const ui::ThemeProvider* provider = [[self window] themeProvider];
switch (severity_) {
case AppMenuIconController::Severity::NONE:
- return themeIsDark ? SK_ColorWHITE : gfx::kChromeIconGrey;
+ return themeIsDark ? SK_ColorWHITE
+ : provider && provider->ShouldIncreaseContrast()
Mark Mentovai 2017/02/23 01:54:16 I suggest but don’t require (parentheses) around e
+ ? SK_ColorBLACK
+ : gfx::kChromeIconGrey;
break;
case AppMenuIconController::Severity::LOW:

Powered by Google App Engine
This is Rietveld 408576698