Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issue 2710103002: [dart:io][windows] Set up CRT error handling behavior (Closed)

Created:
3 years, 10 months ago by zra
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io][windows] Set up CRT error handling behavior fixes #28852 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/30da80fb176a4209b0838884192fd4c69c81f8c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M runtime/bin/platform_win.cc View 4 chunks +22 lines, -1 line 0 comments Download
M tests/standalone/io/file_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 10 months ago (2017-02-22 20:56:39 UTC) #2
Florian Schneider
lgtm
3 years, 10 months ago (2017-02-22 21:19:19 UTC) #3
zra
3 years, 10 months ago (2017-02-22 21:55:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
30da80fb176a4209b0838884192fd4c69c81f8c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698