Chromium Code Reviews
DescriptionRevert of Add DidSaveScrollOrScaleState flag to prevent restoreScrollPositionAndViewState restore from default (patchset #19 id:380001 of https://codereview.chromium.org/2628683003/ )
Reason for revert:
Memory regression. https://bugs.chromium.org/p/chromium/issues/detail?id=694569
Original issue's description:
> Add DidSaveScrollOrScaleState flag to prevent restoreScrollPositionAndViewState restore
> from default
>
> This flaky is caused by |FrameLoader::restoreScrollPositionAndViewState| called
> before |FrameLoader::processFragment| in |checkCompleted| and restore from
> default.
>
> So we add DidSaveScrollOrScaleState flag to prevent restoreScrollPositionAndViewState
> restore from default.
>
>
> BUG=672545
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Review-Url: https://codereview.chromium.org/2628683003
> Cr-Commit-Position: refs/heads/master@{#451111}
> Committed: https://chromium.googlesource.com/chromium/src/+/1033be6d096d430b3d1fe6439550448b2374ea4c
TBR=bokan@chromium.org,majidvp@chromium.org,japhet@chromium.org,alexmos@chromium.org,creis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Patch Set 1 #Patch Set 2 : rebase update #Messages
Total messages: 8 (5 generated)
|