Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2710063002: Revert of Add DidSaveScrollOrScaleState flag to prevent restoreScrollPosition... (Closed)

Created:
3 years, 10 months ago by chaopeng
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, gavinp+loader_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add DidSaveScrollOrScaleState flag to prevent restoreScrollPositionAndViewState restore from default (patchset #19 id:380001 of https://codereview.chromium.org/2628683003/ ) Reason for revert: Memory regression. https://bugs.chromium.org/p/chromium/issues/detail?id=694569 Original issue's description: > Add DidSaveScrollOrScaleState flag to prevent restoreScrollPositionAndViewState restore > from default > > This flaky is caused by |FrameLoader::restoreScrollPositionAndViewState| called > before |FrameLoader::processFragment| in |checkCompleted| and restore from > default. > > So we add DidSaveScrollOrScaleState flag to prevent restoreScrollPositionAndViewState > restore from default. > > > BUG=672545 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2628683003 > Cr-Commit-Position: refs/heads/master@{#451111} > Committed: https://chromium.googlesource.com/chromium/src/+/1033be6d096d430b3d1fe6439550448b2374ea4c TBR=bokan@chromium.org,majidvp@chromium.org,japhet@chromium.org,alexmos@chromium.org,creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=672545 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Patch Set 2 : rebase update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -120 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 chunks +3 lines, -36 lines 0 comments Download
M content/common/page_state_serialization.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/common/page_state_serialization.cc View 1 7 chunks +11 lines, -29 lines 0 comments Download
M content/common/page_state_serialization_unittest.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/history_serialization.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/data/navigation_controller/reload-with-url-anchor.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/page_state/serialized_v23.dat View 1 chunk +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/core/loader/DocumentLoader.cpp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/HistoryItem.h View 1 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/loader/HistoryItem.cpp View 1 4 chunks +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebHistoryItem.cpp View 1 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebHistoryItem.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
chaopeng
Created Revert of Add DidSaveScrollOrScaleState flag to prevent restoreScrollPositionAndViewState restore from default
3 years, 10 months ago (2017-02-22 18:52:28 UTC) #2
Charlie Reis
Is this safe to land? I'm worried this will break session restore for anyone who ...
3 years, 10 months ago (2017-02-22 19:01:31 UTC) #5
bokan
3 years, 10 months ago (2017-02-22 19:04:53 UTC) #6
On 2017/02/22 19:01:31, Charlie Reis wrote:
> Is this safe to land?  I'm worried this will break session restore for anyone
> who upgraded their serialization version from 23 to 24 already.

Doh! Yeah, I hadn't thought of that. Lets scratch the revert and try to repro
locally.

Powered by Google App Engine
This is Rietveld 408576698