HTTP/2 Check header names in HeaderCoalescer

net/spdy/header_coalescer_test.cc

Index: net/spdy/header_coalescer_test.cc
diff --git a/net/spdy/header_coalescer_test.cc b/net/spdy/header_coalescer_test.cc
index 986e775321076f8d89cce04affe463970df0a604..65bd2b06747763effcd28d3d671cad7eb10b5ba7 100644
--- a/net/spdy/header_coalescer_test.cc
+++ b/net/spdy/header_coalescer_test.cc
@@ -76,5 +76,12 @@ TEST_F(HeaderCoalescerTest, CRLFInHeaderValue) {
   EXPECT_TRUE(header_coalescer_.error_seen());
 }
 
+TEST_F(HeaderCoalescerTest, HeaderNameNotValid) {

[asanka, 2017/02/23 17:45:13]

There should be a test that stakes out RFC 7230's definition of header-name
here. I.e. have a test that asserts that a header name containing all possible
tchars is considered valid. We want the tests to make sure we won't reject a
valid header name.

[xunjieli, 2017/02/23 23:07:38]

Done.

+  std::string header_name("\x01\x7F\x80\xff");
+  header_coalescer_.OnHeader(header_name, "foo");
+  EXPECT_TRUE(header_coalescer_.error_seen());
+}

[asanka, 2017/02/23 17:45:13]

Similar to the above test requirement. Add one for a header value made up of all
valid header value chars. That header should be considered valid by
HeaderCoalescer. The goal is to ensure that the doesn't block a valid header.

[xunjieli, 2017/02/23 23:07:37]

Done.

+
 }  // namespace test
+
 }  // namespace net