HTTP/2 Check header names in HeaderCoalescer

net/spdy/header_coalescer.cc

Index: net/spdy/header_coalescer.cc
diff --git a/net/spdy/header_coalescer.cc b/net/spdy/header_coalescer.cc
index 497c07991983a5423c77a16b6e4178d74736521d..99e60dafe507130975705b5e83455bfd8c3e3d98 100644
--- a/net/spdy/header_coalescer.cc
+++ b/net/spdy/header_coalescer.cc
@@ -24,6 +24,12 @@ void HeaderCoalescer::OnHeader(base::StringPiece key, base::StringPiece value) {
     return;
   }
 
+  // RFC 7540 Section 8.1.2 says that header field names are ASCII characters.
+  if (!base::IsStringASCII(key)) {

[asanka, 2017/02/22 19:44:13]

Consider using something like HttpUtil::IsValidHeaderName(). RFC 7540 prescribes
an additional restriction where the header name should be lowercase.

[xunjieli, 2017/02/22 20:14:51]

Done. Thanks for the suggestion!

+    error_seen_ = true;
+    return;
+  }
+
   // 32 byte overhead according to RFC 7540 Section 6.5.2.
   header_list_size_ += key.size() + value.size() + 32;
   if (header_list_size_ > kMaxHeaderListSize) {