Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: ui/aura/mus/window_port_mus.cc

Issue 2710023007: Make WindowTree::SetModal() take the type. (Closed)
Patch Set: address feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/mus/window_port_mus.h ('k') | ui/aura/mus/window_tree_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/mus/window_port_mus.cc
diff --git a/ui/aura/mus/window_port_mus.cc b/ui/aura/mus/window_port_mus.cc
index 28e23de5df16ad90278cf5c40b9fa3e4aa509492..d3b1fb9f3b43f7828280b12c2febb47ed853731c 100644
--- a/ui/aura/mus/window_port_mus.cc
+++ b/ui/aura/mus/window_port_mus.cc
@@ -430,9 +430,9 @@ std::unique_ptr<ui::PropertyData> WindowPortMus::OnWillChangeProperty(
return window_tree_client_->OnWindowMusWillChangeProperty(this, key);
}
-void WindowPortMus::OnPropertyChanged(
- const void* key,
- std::unique_ptr<ui::PropertyData> data) {
+void WindowPortMus::OnPropertyChanged(const void* key,
+ int64_t old_value,
+ std::unique_ptr<ui::PropertyData> data) {
// See comment in OnWillChangeProperty() as to why |window_| may be null.
if (!window_)
return;
@@ -444,7 +444,8 @@ void WindowPortMus::OnPropertyChanged(
// we ever have a case where changing a property cascades into changing the
// same property?
if (!RemoveChangeByTypeAndData(ServerChangeType::PROPERTY, change_data))
- window_tree_client_->OnWindowMusPropertyChanged(this, key, std::move(data));
+ window_tree_client_->OnWindowMusPropertyChanged(this, key, old_value,
+ std::move(data));
}
} // namespace aura
« no previous file with comments | « ui/aura/mus/window_port_mus.h ('k') | ui/aura/mus/window_tree_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698