services/ui/ws/window_tree.h - Issue 2710023007: Make WindowTree::SetModal() take the type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/ws/window_tree.h

Issue 2710023007: Make WindowTree::SetModal() take the type. (Closed)

Patch Set: address feedback. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/ui/ws/window_tree.h

diff --git a/services/ui/ws/window_tree.h b/services/ui/ws/window_tree.h

index 6fc0a9667b579556948df487d0d4d49257b1f4bc..63da72ffc7945b845e4023af52690666f94364f4 100644

--- a/services/ui/ws/window_tree.h

+++ b/services/ui/ws/window_tree.h

@@ -173,7 +173,7 @@ class WindowTree : public mojom::WindowTree,

bool AddTransientWindow(const ClientWindowId& window_id,

const ClientWindowId& transient_window_id);

bool DeleteWindow(const ClientWindowId& window_id);

- bool SetModal(const ClientWindowId& window_id);

+ bool SetModalType(const ClientWindowId& window_id, ModalType modal_type);

std::vector<const ServerWindow*> GetWindowTree(

const ClientWindowId& window_id) const;

bool SetWindowVisibility(const ClientWindowId& window_id, bool visible);

@@ -389,7 +389,7 @@ class WindowTree : public mojom::WindowTree,

Id transient_window) override;

void RemoveTransientWindowFromParent(uint32_t change_id,

Id transient_window_id) override;

- void SetModal(uint32_t change_id, Id window_id) override;

+ void SetModalType(uint32_t change_id, Id window_id, ModalType type) override;

void ReorderWindow(uint32_t change_Id,

Id window_id,

Id relative_window_id,

« no previous file with comments | « services/ui/ws/window_manager_state.cc ('k') | services/ui/ws/window_tree.cc » ('j') | no next file with comments »