Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Unified Diff: services/ui/ws/event_dispatcher_unittest.cc

Issue 2710023007: Make WindowTree::SetModal() take the type. (Closed)
Patch Set: Don't check for system modal when AddTransientWindow(). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/event_dispatcher_unittest.cc
diff --git a/services/ui/ws/event_dispatcher_unittest.cc b/services/ui/ws/event_dispatcher_unittest.cc
index 2df37991de72b4370b2c698f157c74ca51ada83d..d7192a2d77059e7da9222f87ab5a6b5a5a5da2b9 100644
--- a/services/ui/ws/event_dispatcher_unittest.cc
+++ b/services/ui/ws/event_dispatcher_unittest.cc
@@ -1375,7 +1375,7 @@ TEST_F(EventDispatcherTest, ModalWindowEventOnModalParent) {
w2->SetBounds(gfx::Rect(50, 10, 10, 10));
w1->AddTransientWindow(w2.get());
- w2->SetModal();
+ w2->SetModalType(MODAL_TYPE_WINDOW);
// Send event that is over |w1|.
const ui::PointerEvent mouse_pressed(ui::MouseEvent(
@@ -1408,7 +1408,7 @@ TEST_F(EventDispatcherTest, ModalWindowEventOnModalChild) {
w2->SetBounds(gfx::Rect(50, 10, 10, 10));
w1->AddTransientWindow(w2.get());
- w2->SetModal();
+ w2->SetModalType(MODAL_TYPE_WINDOW);
// Send event that is over |w2|.
const ui::PointerEvent mouse_pressed(ui::MouseEvent(
@@ -1444,7 +1444,7 @@ TEST_F(EventDispatcherTest, ModalWindowEventOnUnrelatedWindow) {
w3->SetBounds(gfx::Rect(70, 10, 10, 10));
w1->AddTransientWindow(w2.get());
- w2->SetModal();
+ w2->SetModalType(MODAL_TYPE_WINDOW);
// Send event that is over |w3|.
const ui::PointerEvent mouse_pressed(ui::MouseEvent(
@@ -1481,7 +1481,7 @@ TEST_F(EventDispatcherTest, ModalWindowEventOnDescendantOfModalParent) {
w2->SetBounds(gfx::Rect(50, 10, 10, 10));
w1->AddTransientWindow(w2.get());
- w2->SetModal();
+ w2->SetModalType(MODAL_TYPE_WINDOW);
// Send event that is over |w11|.
const ui::PointerEvent mouse_pressed(ui::MouseEvent(
@@ -1510,7 +1510,7 @@ TEST_F(EventDispatcherTest, ModalWindowEventOnSystemModal) {
root_window()->SetBounds(gfx::Rect(0, 0, 100, 100));
w1->SetBounds(gfx::Rect(10, 10, 30, 30));
- w1->SetModal();
+ w1->SetModalType(MODAL_TYPE_SYSTEM);
// Send event that is over |w1|.
const ui::PointerEvent mouse_pressed(ui::MouseEvent(
@@ -1539,7 +1539,7 @@ TEST_F(EventDispatcherTest, ModalWindowEventOutsideSystemModal) {
root_window()->SetBounds(gfx::Rect(0, 0, 100, 100));
w1->SetBounds(gfx::Rect(10, 10, 30, 30));
- w1->SetModal();
+ w1->SetModalType(MODAL_TYPE_SYSTEM);
event_dispatcher()->AddSystemModalWindow(w1.get());
// Send event that is over |w1|.
@@ -1576,7 +1576,7 @@ TEST_F(EventDispatcherTest, ModalWindowSetCaptureDescendantOfModalParent) {
w2->SetBounds(gfx::Rect(50, 10, 10, 10));
w1->AddTransientWindow(w2.get());
- w2->SetModal();
+ w2->SetModalType(MODAL_TYPE_WINDOW);
EXPECT_FALSE(event_dispatcher()->SetCaptureWindow(w11.get(), kClientAreaId));
EXPECT_EQ(nullptr, event_dispatcher()->capture_window());
@@ -1594,7 +1594,7 @@ TEST_F(EventDispatcherTest, ModalWindowSetCaptureUnrelatedWindow) {
w3->SetBounds(gfx::Rect(70, 10, 10, 10));
w1->AddTransientWindow(w2.get());
- w2->SetModal();
+ w2->SetModalType(MODAL_TYPE_WINDOW);
EXPECT_TRUE(event_dispatcher()->SetCaptureWindow(w3.get(), kClientAreaId));
EXPECT_EQ(w3.get(), event_dispatcher()->capture_window());

Powered by Google App Engine
This is Rietveld 408576698