[Doodle] Introduce a DoodleService

components/doodle/doodle_fetcher_impl.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DOODLE_DOODLE_FETCHER_IMPL_H_
 #define COMPONENTS_DOODLE_DOODLE_FETCHER_IMPL_H_
 
 #include <memory>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/optional.h"
+#include "base/time/clock.h"

[Marc Treib, 2017/02/24 14:04:11]

I think std::move needed this to be actually included. Of course, the
alternative would be to just move the SetClockForTesting implementation into the
.cc

[fhorschig, 2017/02/24 16:38:20]

Acknowledged.

 #include "components/doodle/doodle_fetcher.h"
 #include "components/doodle/doodle_types.h"
 #include "net/url_request/url_fetcher_delegate.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "url/gurl.h"
 
 class GoogleURLTracker;
 
 namespace base {
-class Clock;
 class DictionaryValue;
 class Value;
 }
 
 namespace doodle {
 
 // This class provides information about any recent doodle.
 // It works asynchronously and calls a callback when finished fetching the
 // information from the remote enpoint.
 class DoodleFetcherImpl : public DoodleFetcher, public net::URLFetcherDelegate {
@@ skipping 60 matching lines @@
   std::unique_ptr<net::URLFetcher> fetcher_;
 
   base::WeakPtrFactory<DoodleFetcherImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DoodleFetcherImpl);
 };
 
 }  // namespace doodle
 
 #endif  // COMPONENTS_DOODLE_DOODLE_FETCHER_IMPL_H_