Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1817)

Unified Diff: tools/testing/dart/status_file_parser.dart

Issue 2710003005: [test.dart] Complain if there is non-utf8 formatted data in test output (Closed)
Patch Set: Address comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/status_file_parser.dart
diff --git a/tools/testing/dart/status_file_parser.dart b/tools/testing/dart/status_file_parser.dart
index 3ede28c28e80eab93c108d0aabb9255de5977551..eea74c64a36daa170d3368145537ae2ea4ff60ef 100644
--- a/tools/testing/dart/status_file_parser.dart
+++ b/tools/testing/dart/status_file_parser.dart
@@ -27,6 +27,7 @@ class Expectation {
static Expectation STATIC_WARNING = byName('StaticWarning');
static Expectation MISSING_STATIC_WARNING = byName('MissingStaticWarning');
static Expectation PUB_GET_ERROR = byName('PubGetError');
+ static Expectation NON_UTF8_ERROR = byName('NonUtf8Output');
// Special 'CRASH' cases
static Expectation DARTK_CRASH = byName('DartkCrash');
@@ -80,6 +81,7 @@ class Expectation {
build("MissingCompileTimeError", group: fail);
build("MissingRuntimeError", group: fail);
build("RuntimeError", group: fail);
+ build("NonUtf8Output", group: fail);
// Dartk sub expectations
build("DartkCrash", group: crash);

Powered by Google App Engine
This is Rietveld 408576698