Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(953)

Issue 27100003: Add support for nullable operation arguments in IDL files (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Add support for nullable operation arguments in IDL files Add support for nullable operation arguments in IDL files. If a non-pointer type is marked as nullable in the IDL, a pointer will be passed to the implementation so that the implementation can check for the null case. For e.g., a double? argument in IDL will be passed as double* to the implementation. This will help us get rid of some custom bindings code. R=haraken BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159602

Patch Set 1 #

Patch Set 2 : Simplify a little #

Patch Set 3 : Add test for optional argument #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -5 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 3 chunks +12 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 3 chunks +35 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Inactive
7 years, 2 months ago (2013-10-12 19:33:45 UTC) #1
haraken
Sorry for being late. LGTM.
7 years, 2 months ago (2013-10-14 12:20:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27100003/7001
7 years, 2 months ago (2013-10-14 13:18:50 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=11015
7 years, 2 months ago (2013-10-14 15:15:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27100003/7001
7 years, 2 months ago (2013-10-14 16:39:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=11061
7 years, 2 months ago (2013-10-14 18:17:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27100003/7001
7 years, 2 months ago (2013-10-14 19:59:25 UTC) #7
commit-bot: I haz the power
7 years, 2 months ago (2013-10-14 21:05:58 UTC) #8
Message was sent while issue was closed.
Change committed as 159602

Powered by Google App Engine
This is Rietveld 408576698