Selection API: Do not change focus by Selection functions.

Selection API: Do not change focus by Selection functions.

Tests:
* editing/selection/selection-no-focus-change.html
 New test covering the behavior change.

* editing/editing.js
 Calls focus() before calling collapse() not to break many tests.
 However, this additional focus() will add one additional editing delegate log line.

* spelling/spellcheck_test.js
 Calls focus() before setting selection not to break many tests.

* Many other tests
  Calls focus() before Selection functions.

BUG=690272, 695211

[tkent, 2017-02-23 05:26:40]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 05:26:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 07:02:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 07:02:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2017-02-23 08:10:22]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 08:10:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-23 08:14:13]

Patchset #1 (id:1) has been deleted

[tkent, 2017-02-23 09:59:00]

Description was changed from

==========
Selection API: Do not change focus by Selection functions.

BUG=690272,695211
==========

to

==========
Selection API: Do not change focus by Selection functions.

Tests:
* editing/selection/selection-no-focus-change.html
 New test covering the behavior change.

* editing/editing.js
 Calls focus() before calling collapse()

BUG=690272,695211
==========

[tkent, 2017-02-23 10:00:08]

Description was changed from

==========
Selection API: Do not change focus by Selection functions.

Tests:
* editing/selection/selection-no-focus-change.html
 New test covering the behavior change.

* editing/editing.js
 Calls focus() before calling collapse()

BUG=690272,695211
==========

to

==========
Selection API: Do not change focus by Selection functions.

Tests:
* editing/selection/selection-no-focus-change.html
 New test covering the behavior change.

* editing/editing.js
 Calls focus() before calling collapse() not to break many tests.
 However, this additional focus() will add one additional editing delegate log
line.

* 

BUG=690272,695211
==========

[tkent, 2017-02-23 10:01:10]

Description was changed from

==========
Selection API: Do not change focus by Selection functions.

Tests:
* editing/selection/selection-no-focus-change.html
 New test covering the behavior change.

* editing/editing.js
 Calls focus() before calling collapse() not to break many tests.
 However, this additional focus() will add one additional editing delegate log
line.

* 

BUG=690272,695211
==========

to

==========
Selection API: Do not change focus by Selection functions.

Tests:
* editing/selection/selection-no-focus-change.html
 New test covering the behavior change.

* editing/editing.js
 Calls focus() before calling collapse() not to break many tests.
 However, this additional focus() will add one additional editing delegate log
line.

* spelling/spellcheck_test.js
 Calls focus() before setting selection not to break many tests.

* Many other tests
  Calls focus() before Selection functions.

BUG=690272,695211
==========

[tkent, 2017-02-23 10:01:42]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-23 10:01:43]

yoichio@, yosin@, would you review this please?

[commit-bot: I haz the power, 2017-02-23 11:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 11:23:18]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-02-24 01:54:42]

On 2017/02/23 10:01:43, tkent wrote:
> yoichio@, yosin@, would you review this please?

I think this needs intent to ship.

[yoichio, 2017-02-24 01:54:52]

https://codereview.chromium.org/2709983005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/editing.js (right):

https://codereview.chromium.org/2709983005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/editing.js:931: focusTarget.focus();
Why do we need to focus on all ancestors?

[tkent, 2017-02-24 01:59:11]

On 2017/02/24 at 01:54:42, yoichio wrote:
> I think this needs intent to ship.

Yeah, I think so too :-)

I'll close this CL, and will add a UseCounter.
I'll take another approach to fix crbug.com/695211.  It just needs a sequence of
FS::setSelection() and acheRangeIfSelectionOfDocument() is atomic.

[tkent, 2017-02-24 01:59:44]

https://codereview.chromium.org/2709983005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/editing.js (right):

https://codereview.chromium.org/2709983005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/editing.js:931: focusTarget.focus();
On 2017/02/24 at 01:54:51, yoichio wrote:
> Why do we need to focus on all ancestors?

This just focus on the nearest focusable ancestor.