Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp

Issue 2709983004: WIP bindings: Add support for the record<K,V> WebIDL type. (Closed)
Patch Set: Rebased patch using NativeValueTraits for IDL types Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
index 9af7fc830b426f13dd2fbe01296185eb8fd70389..5fffd88aa22a5c7157981073c73a7bbc78e7d654 100644
--- a/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp
@@ -122,16 +122,6 @@ bool Dictionary::getInternal(const v8::Local<v8::Value>& key,
return m_dictionaryObject->Get(v8Context(), key).ToLocal(&result);
}
-WARN_UNUSED_RESULT static v8::MaybeLocal<v8::String> getStringValueInArray(
- v8::Local<v8::Context> context,
- v8::Local<v8::Array> array,
- uint32_t index) {
- v8::Local<v8::Value> value;
- if (!array->Get(context, index).ToLocal(&value))
- return v8::MaybeLocal<v8::String>();
- return value->ToString(context);
-}
-
HashMap<String, String> Dictionary::getOwnPropertiesAsStringHashMap(
ExceptionState& exceptionState) const {
if (m_dictionaryObject.IsEmpty())

Powered by Google App Engine
This is Rietveld 408576698