Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2709943005: Canonicalize mixin applications by their name (Closed)

Created:
3 years, 10 months ago by karlklose
Modified:
3 years, 10 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -49 lines) Patch
M pkg/front_end/.analysis_options View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compile_platform.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart View 2 chunks +28 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/mixin.dart.direct.expect View 1 chunk +0 lines, -14 lines 0 comments Download
M pkg/front_end/test/fasta/mixin.dart.outline.expect View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
karlklose
3 years, 10 months ago (2017-02-23 14:35:08 UTC) #1
ahe
lgtm https://codereview.chromium.org/2709943005/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart File pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart (right): https://codereview.chromium.org/2709943005/diff/1/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart#newcode354 pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart:354: boundlessTypeVariables.addAll(part.boundlessTypeVariables); assert(mixinApplicationClasses.isEmpty);
3 years, 10 months ago (2017-02-23 14:38:15 UTC) #2
karlklose
Done
3 years, 10 months ago (2017-02-23 14:50:12 UTC) #3
karlklose
3 years, 10 months ago (2017-02-23 14:50:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5c2187bdd187b33d8d2fddc1afd4981064d84925 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698