Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2382)

Unified Diff: ash/common/system/tray/tray_constants.h

Issue 2709903004: Consolidate some more ash tray constants. (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/system/tray/tray_constants.h
diff --git a/ash/common/system/tray/tray_constants.h b/ash/common/system/tray/tray_constants.h
index e457f1dfd1ab1b17558e13fc4dac8b7a6c7f3213..2c46db0b2300d883a04fa28225a602453ab37dd2 100644
--- a/ash/common/system/tray/tray_constants.h
+++ b/ash/common/system/tray/tray_constants.h
@@ -28,6 +28,9 @@ extern const int kTrayImageItemHorizontalPaddingVerticalAlignment;
ASH_EXPORT extern const int kTrayItemSize;
+// Extra padding used beside a single icon in the tray area of the shelf.
+extern const int kTrayImageItemPadding;
+
extern const int kTrayLabelItemHorizontalPaddingBottomAlignment;
extern const int kTrayLabelItemVerticalPaddingVerticalAlignment;
@@ -48,6 +51,15 @@ extern const int kTrayPopupButtonEndMargin;
// in the system menu.
extern const int kTrayPopupLabelHorizontalPadding;
+// The minimum/default height of the rows in the system tray menu.
+extern const int kTrayPopupItemMinHeight;
+
+// The width used for the first region of the row (which holds an image).
+extern const int kTrayPopupItemMinStartWidth;
+
+// The width used for the first region of the row (usually a more arrow).
tdanderson 2017/02/28 17:08:18 nit: end region
Evan Stade 2017/03/01 04:28:54 Done.
+extern const int kTrayPopupItemMinEndWidth;
+
// When transitioning between a detailed and a default view, this delay is used
// before the transition starts.
ASH_EXPORT extern const int kTrayDetailedViewTransitionDelayMs;
@@ -138,48 +150,6 @@ extern const int kTrayPopupInkDropCornerRadius;
// The height of the system info row.
extern const int kTrayPopupSystemInfoRowHeight;
-enum TrayConstant {
- // A legacy height value used in non-MD calculations for applying additional
- // borders on tray items.
- TRAY_ITEM_HEIGHT_LEGACY,
-
- // Padding between the edge of shelf and the item in status tray area.
- TRAY_PADDING_FROM_EDGE_OF_SHELF,
-
- // The minimum height of the rows in the system tray menu.
- TRAY_POPUP_ITEM_MIN_HEIGHT,
-
- // The maximum height of the rows in the system tray menu.
- TRAY_POPUP_ITEM_MAX_HEIGHT,
-
- // The width used for the main image of the row. This applies to all rows
- // in the system menu that have a main image (e.g. default and detailed).
- TRAY_POPUP_ITEM_MAIN_IMAGE_CONTAINER_WIDTH,
-
- // The width used for the images used in the 'more' region of default rows.
- TRAY_POPUP_ITEM_MORE_IMAGE_SIZE,
-
- // The horizontal inset in the 'more' region of default rows.
- TRAY_POPUP_ITEM_MORE_REGION_HORIZONTAL_INSET,
-
- // The left inset for all tray system menu rows.
- TRAY_POPUP_ITEM_LEFT_INSET,
-
- // The minimum default width for the left container of the system menu rows.
- TRAY_POPUP_ITEM_MIN_START_WIDTH,
-
- // The minimum default width for the right container of the system menu rows.
- TRAY_POPUP_ITEM_MIN_END_WIDTH,
-
- // The icon size of opt-in IME menu tray.
- TRAY_IME_MENU_ICON,
-
- // Extra padding used beside a single icon in the tray area of the shelf.
- TRAY_IMAGE_ITEM_PADDING,
-};
-
-ASH_EXPORT int GetTrayConstant(TrayConstant constant);
-
namespace test {
const int kSettingsTrayItemViewId = 10000;
const int kAccessibilityTrayItemViewId = 10001;

Powered by Google App Engine
This is Rietveld 408576698