Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus() (Closed)
Patch Set: Fixing the layout tests (verifying frameWidget != nullptr) Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 2660 matching lines...) Expand 10 before | Expand all | Expand 10 after
2671 if (!document().page()->focusController().setFocusedElement( 2671 if (!document().page()->focusController().setFocusedElement(
2672 this, document().frame(), params)) 2672 this, document().frame(), params))
2673 return; 2673 return;
2674 2674
2675 if (document().focusedElement() == this && 2675 if (document().focusedElement() == this &&
2676 document().frame()->hasReceivedUserGesture()) { 2676 document().frame()->hasReceivedUserGesture()) {
2677 // Bring up the keyboard in the context of anything triggered by a user 2677 // Bring up the keyboard in the context of anything triggered by a user
2678 // gesture. Since tracking that across arbitrary boundaries (eg. 2678 // gesture. Since tracking that across arbitrary boundaries (eg.
2679 // animations) is difficult, for now we match IE's heuristic and bring 2679 // animations) is difficult, for now we match IE's heuristic and bring
2680 // up the keyboard if there's been any gesture since load. 2680 // up the keyboard if there's been any gesture since load.
2681 document().page()->chromeClient().showVirtualKeyboardOnElementFocus(); 2681 document().page()->chromeClient().showVirtualKeyboardOnElementFocus(
2682 document().frame());
2682 } 2683 }
2683 } 2684 }
2684 2685
2685 void Element::updateFocusAppearance( 2686 void Element::updateFocusAppearance(
2686 SelectionBehaviorOnFocus selectionBehavior) { 2687 SelectionBehaviorOnFocus selectionBehavior) {
2687 if (selectionBehavior == SelectionBehaviorOnFocus::None) 2688 if (selectionBehavior == SelectionBehaviorOnFocus::None)
2688 return; 2689 return;
2689 if (isRootEditableElement(*this)) { 2690 if (isRootEditableElement(*this)) {
2690 LocalFrame* frame = document().frame(); 2691 LocalFrame* frame = document().frame();
2691 if (!frame) 2692 if (!frame)
(...skipping 1450 matching lines...) Expand 10 before | Expand all | Expand 10 after
4142 } 4143 }
4143 4144
4144 DEFINE_TRACE_WRAPPERS(Element) { 4145 DEFINE_TRACE_WRAPPERS(Element) {
4145 if (hasRareData()) { 4146 if (hasRareData()) {
4146 visitor->traceWrappers(elementRareData()); 4147 visitor->traceWrappers(elementRareData());
4147 } 4148 }
4148 ContainerNode::traceWrappers(visitor); 4149 ContainerNode::traceWrappers(visitor);
4149 } 4150 }
4150 4151
4151 } // namespace blink 4152 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698