Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2709813007: Remove WebViewClient::showVirtualKeyboardOnElementFocus() (Closed)
Patch Set: Made the test better Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * (C) 2007 Eric Seidel (eric@webkit.org) 9 * (C) 2007 Eric Seidel (eric@webkit.org)
10 * 10 *
(...skipping 2716 matching lines...) Expand 10 before | Expand all | Expand 10 after
2727 if (!document().page()->focusController().setFocusedElement( 2727 if (!document().page()->focusController().setFocusedElement(
2728 this, document().frame(), params)) 2728 this, document().frame(), params))
2729 return; 2729 return;
2730 2730
2731 if (document().focusedElement() == this && 2731 if (document().focusedElement() == this &&
2732 document().frame()->hasReceivedUserGesture()) { 2732 document().frame()->hasReceivedUserGesture()) {
2733 // Bring up the keyboard in the context of anything triggered by a user 2733 // Bring up the keyboard in the context of anything triggered by a user
2734 // gesture. Since tracking that across arbitrary boundaries (eg. 2734 // gesture. Since tracking that across arbitrary boundaries (eg.
2735 // animations) is difficult, for now we match IE's heuristic and bring 2735 // animations) is difficult, for now we match IE's heuristic and bring
2736 // up the keyboard if there's been any gesture since load. 2736 // up the keyboard if there's been any gesture since load.
2737 document().page()->chromeClient().showVirtualKeyboardOnElementFocus(); 2737 document().page()->chromeClient().showVirtualKeyboardOnElementFocus(
2738 document().frame());
2738 } 2739 }
2739 } 2740 }
2740 2741
2741 void Element::updateFocusAppearance( 2742 void Element::updateFocusAppearance(
2742 SelectionBehaviorOnFocus selectionBehavior) { 2743 SelectionBehaviorOnFocus selectionBehavior) {
2743 if (selectionBehavior == SelectionBehaviorOnFocus::None) 2744 if (selectionBehavior == SelectionBehaviorOnFocus::None)
2744 return; 2745 return;
2745 if (isRootEditableElement(*this)) { 2746 if (isRootEditableElement(*this)) {
2746 LocalFrame* frame = document().frame(); 2747 LocalFrame* frame = document().frame();
2747 if (!frame) 2748 if (!frame)
(...skipping 1479 matching lines...) Expand 10 before | Expand all | Expand 10 after
4227 } 4228 }
4228 4229
4229 DEFINE_TRACE_WRAPPERS(Element) { 4230 DEFINE_TRACE_WRAPPERS(Element) {
4230 if (hasRareData()) { 4231 if (hasRareData()) {
4231 visitor->traceWrappers(elementRareData()); 4232 visitor->traceWrappers(elementRareData());
4232 } 4233 }
4233 ContainerNode::traceWrappers(visitor); 4234 ContainerNode::traceWrappers(visitor);
4234 } 4235 }
4235 4236
4236 } // namespace blink 4237 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698