Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2709783003: Parse optional and named parameters. (Closed)
Patch Set: Add 'FormalParameterType kind' to endFormalParameter() and add handleFormalParameterWithoutValue(). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
index a5d08dd00323c0a8d710fdd8d2507f562f32b250..56d8b4f248148bd2483edcea8a25e0ebc84b9fb9 100644
--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
@@ -372,7 +372,7 @@ class OutlineBuilder extends UnhandledListener {
}
@override
- void endFormalParameter(Token thisKeyword) {
+ void endFormalParameter(Token thisKeyword, FormalParameterType kind) {
debugEvent("FormalParameter");
String name = pop();
TypeBuilder type = pop();
@@ -390,6 +390,12 @@ class OutlineBuilder extends UnhandledListener {
}
@override
+ void handleFormalParameterWithoutValue(Token token) {
+ debugEvent("FormalParameterWithoutValue");
+ // Ignored for now.
+ }
+
+ @override
void endFunctionTypedFormalParameter(Token token) {
debugEvent("FunctionTypedFormalParameter");
pop(); // Function type parameters.

Powered by Google App Engine
This is Rietveld 408576698