Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: pkg/analyzer/test/generated/parser_fasta_test.dart

Issue 2709783003: Parse optional and named parameters. (Closed)
Patch Set: Add 'FormalParameterType kind' to endFormalParameter() and add handleFormalParameterWithoutValue(). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/parser_fasta_test.dart
diff --git a/pkg/analyzer/test/generated/parser_fasta_test.dart b/pkg/analyzer/test/generated/parser_fasta_test.dart
index 1e0353f8d7992916010a6013d602a3e59cc070f4..ab31b553875748c5554b17ec766b5d727e6fafb8 100644
--- a/pkg/analyzer/test/generated/parser_fasta_test.dart
+++ b/pkg/analyzer/test/generated/parser_fasta_test.dart
@@ -333,20 +333,19 @@ class FastaParserTestCase extends Object
@override
FormalParameter parseFormalParameter(String code, ParameterKind kind,
{List<ErrorCode> errorCodes: const <ErrorCode>[]}) {
- fasta.FormalParameterType type;
+ String parametersCode;
if (kind == ParameterKind.REQUIRED) {
- type = fasta.FormalParameterType.REQUIRED;
+ parametersCode = '($code)';
} else if (kind == ParameterKind.POSITIONAL) {
- type = fasta.FormalParameterType.POSITIONAL;
+ parametersCode = '([$code])';
} else if (kind == ParameterKind.NAMED) {
- type = fasta.FormalParameterType.NAMED;
+ parametersCode = '({$code})';
} else {
fail('$kind');
}
- return _runParser(
- code,
- (parser) => (token) => parser.parseFormalParameter(token, type),
- errorCodes) as FormalParameter;
+ FormalParameterList list = parseFormalParameterList(parametersCode,
+ inFunctionType: false, errorCodes: errorCodes);
+ return list.parameters.single;
}
@override
@@ -498,34 +497,6 @@ class FormalParameterParserTest_Fasta extends FastaParserTestCase
@override
@failingTest
- void test_parseFormalParameter_final_named() {
- // TODO(scheglov): Unhandled event: ValuedFormalParameter
- super.test_parseFormalParameter_final_named();
- }
-
- @override
- @failingTest
- void test_parseFormalParameter_final_positional() {
- // TODO(scheglov): Unhandled event: ValuedFormalParameter
- super.test_parseFormalParameter_final_positional();
- }
-
- @override
- @failingTest
- void test_parseFormalParameter_final_type_named() {
- // TODO(scheglov): Unhandled event: ValuedFormalParameter
- super.test_parseFormalParameter_final_type_named();
- }
-
- @override
- @failingTest
- void test_parseFormalParameter_final_type_positional() {
- // TODO(scheglov): Unhandled event: ValuedFormalParameter
- super.test_parseFormalParameter_final_type_positional();
- }
-
- @override
- @failingTest
void test_parseFormalParameter_type_function() {
// TODO(scheglov): Unhandled event: FunctionTypedFormalParameter
super.test_parseFormalParameter_type_function();
@@ -533,34 +504,6 @@ class FormalParameterParserTest_Fasta extends FastaParserTestCase
@override
@failingTest
- void test_parseFormalParameter_type_named() {
- // TODO(scheglov): Unhandled event: ValuedFormalParameter
- super.test_parseFormalParameter_type_named();
- }
-
- @override
- @failingTest
- void test_parseFormalParameter_type_positional() {
- // TODO(scheglov): Unhandled event: ValuedFormalParameter
- super.test_parseFormalParameter_type_positional();
- }
-
- @override
- @failingTest
- void test_parseFormalParameter_var_named() {
- // TODO(scheglov): Unhandled event: ValuedFormalParameter
- super.test_parseFormalParameter_var_named();
- }
-
- @override
- @failingTest
- void test_parseFormalParameter_var_positional() {
- // TODO(scheglov): Unhandled event: ValuedFormalParameter
- super.test_parseFormalParameter_var_positional();
- }
-
- @override
- @failingTest
void test_parseFormalParameterList_named_multiple() {
// TODO(scheglov): Unhandled event: ValuedFormalParameter
super.test_parseFormalParameterList_named_multiple();
« no previous file with comments | « no previous file | pkg/compiler/lib/src/parser/node_listener.dart » ('j') | pkg/compiler/lib/src/parser/node_listener.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698