Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart

Issue 2709753006: Minor fixes to AstBuilder. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
index a63af7f9ac69314a36f08e0b54e96eb0793914d4..fcf2b398008b902142cea0f4bd52e7c48b7fd21d 100644
--- a/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
+++ b/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart
@@ -444,7 +444,7 @@ class AstBuilder extends ScopeListener {
TypeArgumentList arguments = pop();
Identifier name = pop();
// TODO(paulberry,ahe): what if the type doesn't resolve to a class
- // element?
+ // element? Try to share code with BodyBuilder.builderToFirstExpression.
KernelClassElement cls = name.staticElement;
if (cls == null) {
// TODO(paulberry): This is a kludge. Ideally we should already have
@@ -917,7 +917,8 @@ class AstBuilder extends ScopeListener {
} else {
var prefix = pop();
if (prefix is SimpleIdentifier) {
- // TODO(paulberry): resolve [identifier].
+ // TODO(paulberry): resolve [identifier]. Note that BodyBuilder handles
+ // this situation using SendAccessor.
push(ast.prefixedIdentifier(
prefix, toAnalyzerToken(period), identifier));
} else {
@@ -1034,10 +1035,11 @@ class AstBuilder extends ScopeListener {
List<ConstructorInitializer> initializers = null; // TODO(paulberry)
Token separator = null; // TODO(paulberry)
FormalParameterList parameters = pop();
- TypeParameterList typeParameters = pop();
+ /* TypeParameterList typeParameters = */ pop(); // TODO(paulberry)
var name = pop();
- analyzer.Token propertyKeyword = toAnalyzerToken(getOrSet);
- TypeAnnotation returnType = pop();
+ // TODO(paulberry)
+ // analyzer.Token propertyKeyword = toAnalyzerToken(getOrSet);
+ /* TypeAnnotation returnType = */ pop(); // TODO(paulberry)
Token externalKeyword = null;
Token constKeyword = null;
@@ -1067,7 +1069,7 @@ class AstBuilder extends ScopeListener {
Token period;
SimpleIdentifier name2;
if (name is SimpleIdentifier) {
- SimpleIdentifier returnType2 = name;
+ returnType2 = name;
}
push(ast.constructorDeclaration(
comment,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698