Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 270973002: Don't start demo mode on a test image. (Closed)

Created:
6 years, 7 months ago by rkc
Modified:
6 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 2 chunks +9 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (0 generated)
rkc
6 years, 7 months ago (2014-05-09 00:00:55 UTC) #1
xiyuan
lgtm https://codereview.chromium.org/270973002/diff/1/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc (right): https://codereview.chromium.org/270973002/diff/1/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc#newcode173 chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc:173: if (!base::SysInfo::GetLsbReleaseValue("CHROMEOS_RELEASE_TRACK", &track) || nit: combine this and ...
6 years, 7 months ago (2014-05-09 01:08:17 UTC) #2
rkc
https://codereview.chromium.org/270973002/diff/1/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc (right): https://codereview.chromium.org/270973002/diff/1/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc#newcode173 chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc:173: if (!base::SysInfo::GetLsbReleaseValue("CHROMEOS_RELEASE_TRACK", &track) || On 2014/05/09 01:08:17, xiyuan wrote: ...
6 years, 7 months ago (2014-05-09 04:44:54 UTC) #3
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 7 months ago (2014-05-09 04:44:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/270973002/1
6 years, 7 months ago (2014-05-09 04:48:49 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 04:41:25 UTC) #6
Message was sent while issue was closed.
Change committed as 269525

Powered by Google App Engine
This is Rietveld 408576698