Initial implementation of RtpTransportControllerReceive and related interfaces.

webrtc/call/flexfec_receive_stream_impl.h

Index: webrtc/call/flexfec_receive_stream_impl.h
diff --git a/webrtc/call/flexfec_receive_stream_impl.h b/webrtc/call/flexfec_receive_stream_impl.h
index 705182906cd060c6737b4f8ee76a338e4d32b7ca..b65531ac683e526059b457a32de3a39c95cab110 100644
--- a/webrtc/call/flexfec_receive_stream_impl.h
+++ b/webrtc/call/flexfec_receive_stream_impl.h
@@ -15,6 +15,8 @@
 
 #include "webrtc/base/criticalsection.h"
 #include "webrtc/call/flexfec_receive_stream.h"
+#include "webrtc/call/rtp_transport_controller_receive.h"
+#include "webrtc/modules/rtp_rtcp/source/rtp_header_extension.h"
 
 namespace webrtc {
 
@@ -26,7 +28,9 @@ class RtcpRttStats;
 class RtpPacketReceived;
 class RtpRtcp;
 
-class FlexfecReceiveStreamImpl : public FlexfecReceiveStream {
+class FlexfecReceiveStreamImpl : public FlexfecReceiveStream,
+                                 public RtpPacketReceiverInterface,
+                                 public RtpPacketSinkInterface {
  public:
   FlexfecReceiveStreamImpl(const Config& config,
                            RecoveredPacketReceiver* recovered_packet_receiver,
@@ -36,8 +40,13 @@ class FlexfecReceiveStreamImpl : public FlexfecReceiveStream {
 
   const Config& GetConfig() const { return config_; }
 
-  // TODO(nisse): Intended to be part of an RtpPacketReceiver interface.
-  void OnRtpPacket(const RtpPacketReceived& packet);
+  // webrtc::RtpPacketReceiverInterface implementation, for the
+  // FlexFEC stream.
+  bool OnRtpPacketReceive(RtpPacketReceived* packet) override;
+
+  // webrtc::RtpPacketSinkInterface implementation, for the media
+  // streams protected by FlexFEC.
+  void OnRtpPacket(const RtpPacketReceived& packet) override;

[pthatcher1, 2017/04/29 00:58:46]

Why do we have two methods that look almost exactly the same with almost the
same names, but not quiet, and then one is for some stuff and one is for other
stuff, but it's not at all clear why or what the distinction is.  One is
magically FlexFec and the other is not, but why?

 
   // Implements FlexfecReceiveStream.
   void Start() override;
@@ -47,6 +56,8 @@ class FlexfecReceiveStreamImpl : public FlexfecReceiveStream {
  private:
   // Config.
   const Config config_;
+  const RtpHeaderExtensionMap rtp_header_extensions_;
+
   bool started_ GUARDED_BY(crit_);
   rtc::CriticalSection crit_;