Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2709713002: Reenable some sample tests and fix how they find their data files (Closed)

Created:
3 years, 10 months ago by erikcorry
Modified:
3 years, 10 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reenable some sample tests and fix how they find their data files R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e8e7b2c83248d8313a3ae634baecb890d35257e6

Patch Set 1 #

Total comments: 3

Patch Set 2 : Revert inadvertent change #

Patch Set 3 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M samples/sample_extension/test/sample_extension_app_snapshot_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M samples/sample_extension/test/sample_extension_test_helper.dart View 1 2 2 chunks +12 lines, -19 lines 0 comments Download
M samples/samples.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 10 months ago (2017-02-21 12:04:06 UTC) #1
kustermann
LGTM https://codereview.chromium.org/2709713002/diff/1/samples/sample_extension/test/sample_extension_test_helper.dart File samples/sample_extension/test/sample_extension_test_helper.dart (right): https://codereview.chromium.org/2709713002/diff/1/samples/sample_extension/test/sample_extension_test_helper.dart#newcode8 samples/sample_extension/test/sample_extension_test_helper.dart:8: import 'dart:io'; import 'dart:isolate'; newline? https://codereview.chromium.org/2709713002/diff/1/samples/sample_extension/test/sample_extension_test_helper.dart#newcode33 samples/sample_extension/test/sample_extension_test_helper.dart:33: return ...
3 years, 10 months ago (2017-02-21 12:06:15 UTC) #2
erikcorry
3 years, 10 months ago (2017-02-21 12:09:05 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
e8e7b2c83248d8313a3ae634baecb890d35257e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698