Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2709703004: Clean up V8ObjectConstructor (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 27cbba23f0ec63cc119640d1127ca46fa581d2e7..dac4a0b7b70320a30c68ac1e40d9de7ed05e05d0 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -697,53 +697,6 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::evaluateModule(
return module->Evaluate(context);
}
-v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObject(
- v8::Isolate* isolate,
- v8::Local<v8::ObjectTemplate> objectTemplate) {
- TRACE_EVENT0("v8", "v8.newInstance");
-
- v8::MicrotasksScope microtasksScope(isolate,
- v8::MicrotasksScope::kDoNotRunMicrotasks);
- v8::MaybeLocal<v8::Object> result =
- objectTemplate->NewInstance(isolate->GetCurrentContext());
- CHECK(!isolate->IsDead());
- return result;
-}
-
-v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObject(
- v8::Isolate* isolate,
- v8::Local<v8::Function> function,
- int argc,
- v8::Local<v8::Value> argv[]) {
- TRACE_EVENT0("v8", "v8.newInstance");
-
- v8::MicrotasksScope microtasksScope(isolate,
- v8::MicrotasksScope::kDoNotRunMicrotasks);
- v8::MaybeLocal<v8::Object> result =
- function->NewInstance(isolate->GetCurrentContext(), argc, argv);
- CHECK(!isolate->IsDead());
- return result;
-}
-
-v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObjectInDocument(
- v8::Isolate* isolate,
- v8::Local<v8::Function> function,
- ExecutionContext* context,
- int argc,
- v8::Local<v8::Value> argv[]) {
- TRACE_EVENT0("v8", "v8.newInstance");
- if (ScriptForbiddenScope::isScriptForbidden()) {
- throwScriptForbiddenException(isolate);
- return v8::MaybeLocal<v8::Object>();
- }
- v8::MicrotasksScope microtasksScope(isolate,
- v8::MicrotasksScope::kRunMicrotasks);
- v8::MaybeLocal<v8::Object> result =
- function->NewInstance(isolate->GetCurrentContext(), argc, argv);
- CHECK(!isolate->IsDead());
- return result;
-}
-
uint32_t V8ScriptRunner::tagForParserCache(
CachedMetadataHandler* cacheHandler) {
return cacheTag(CacheTagParser, cacheHandler);
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698