Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h

Issue 2709703004: Clean up V8ObjectConstructor (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h b/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
index a1f2a1fd128c5379dbafda1497796b830236c698..5c26a6e3834f649748cbdd8bcd3c2e9df7f84a4a 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
@@ -39,8 +39,6 @@
namespace blink {
-class Document;
-
class ConstructorMode {
STACK_ALLOCATED();
@@ -71,18 +69,11 @@ class CORE_EXPORT V8ObjectConstructor {
STATIC_ONLY(V8ObjectConstructor);
public:
- static v8::MaybeLocal<v8::Object> newInstance(v8::Isolate*,
- v8::Local<v8::Function>);
- static v8::MaybeLocal<v8::Object> newInstance(v8::Isolate*,
- v8::Local<v8::Function>,
- int,
- v8::Local<v8::Value> argv[]);
- static v8::MaybeLocal<v8::Object> newInstanceInDocument(
+ static v8::MaybeLocal<v8::Object> newInstance(
v8::Isolate*,
v8::Local<v8::Function>,
- int,
- v8::Local<v8::Value> argv[],
- Document*);
+ int argc = 0,
+ v8::Local<v8::Value> argv[] = nullptr);
static void isValidConstructorMode(
const v8::FunctionCallbackInfo<v8::Value>&);
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698