Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 2709703004: Clean up V8ObjectConstructor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
index 41c662e5b9ff894869551505b8fe012d73ec79c7..d278e15e372b99dd2e59b49f8e988a5949869c45 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.cpp
@@ -698,53 +698,6 @@ v8::MaybeLocal<v8::Value> V8ScriptRunner::evaluateModule(
return module->Evaluate(context);
}
-v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObject(
- v8::Isolate* isolate,
- v8::Local<v8::ObjectTemplate> objectTemplate) {
- TRACE_EVENT0("v8", "v8.newInstance");
-
- v8::MicrotasksScope microtasksScope(isolate,
- v8::MicrotasksScope::kDoNotRunMicrotasks);
- v8::MaybeLocal<v8::Object> result =
- objectTemplate->NewInstance(isolate->GetCurrentContext());
- crashIfIsolateIsDead(isolate);
- return result;
-}
-
-v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObject(
- v8::Isolate* isolate,
- v8::Local<v8::Function> function,
- int argc,
- v8::Local<v8::Value> argv[]) {
- TRACE_EVENT0("v8", "v8.newInstance");
-
- v8::MicrotasksScope microtasksScope(isolate,
- v8::MicrotasksScope::kDoNotRunMicrotasks);
- v8::MaybeLocal<v8::Object> result =
- function->NewInstance(isolate->GetCurrentContext(), argc, argv);
- crashIfIsolateIsDead(isolate);
- return result;
-}
-
-v8::MaybeLocal<v8::Object> V8ScriptRunner::instantiateObjectInDocument(
- v8::Isolate* isolate,
- v8::Local<v8::Function> function,
- ExecutionContext* context,
- int argc,
- v8::Local<v8::Value> argv[]) {
- TRACE_EVENT0("v8", "v8.newInstance");
- if (ScriptForbiddenScope::isScriptForbidden()) {
- throwScriptForbiddenException(isolate);
- return v8::MaybeLocal<v8::Object>();
- }
- v8::MicrotasksScope microtasksScope(isolate,
- v8::MicrotasksScope::kRunMicrotasks);
- v8::MaybeLocal<v8::Object> result =
- function->NewInstance(isolate->GetCurrentContext(), argc, argv);
- crashIfIsolateIsDead(isolate);
- return result;
-}
-
uint32_t V8ScriptRunner::tagForParserCache(
CachedMetadataHandler* cacheHandler) {
return cacheTag(CacheTagParser, cacheHandler);

Powered by Google App Engine
This is Rietveld 408576698