Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h

Issue 2709703004: Clean up V8ObjectConstructor (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h b/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
index a1f2a1fd128c5379dbafda1497796b830236c698..de1e534c103aa40e7bb64fbc2627c96dda0a2408 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ObjectConstructor.h
@@ -39,8 +39,6 @@
namespace blink {
-class Document;
-
class ConstructorMode {
STACK_ALLOCATED();
@@ -77,12 +75,11 @@ class CORE_EXPORT V8ObjectConstructor {
v8::Local<v8::Function>,
int,
v8::Local<v8::Value> argv[]);
- static v8::MaybeLocal<v8::Object> newInstanceInDocument(
+ static v8::MaybeLocal<v8::Object> instantiateObject(
v8::Isolate*,
v8::Local<v8::Function>,
- int,
- v8::Local<v8::Value> argv[],
- Document*);
+ int argc = 0,
+ v8::Local<v8::Value> argv[] = 0);
jbroman 2017/02/21 22:10:28 nit: nullptr, since this is a pointer you're defau
static void isValidConstructorMode(
const v8::FunctionCallbackInfo<v8::Value>&);

Powered by Google App Engine
This is Rietveld 408576698