Clean up V8ObjectConstructor

third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 98 matching lines @@
       v8::Isolate*);
   static v8::MaybeLocal<v8::Value> callFunction(v8::Local<v8::Function>,
                                                 ExecutionContext*,
                                                 v8::Local<v8::Value> receiver,
                                                 int argc,
                                                 v8::Local<v8::Value> info[],
                                                 v8::Isolate*);
   static v8::MaybeLocal<v8::Value> evaluateModule(v8::Local<v8::Module>,
                                                   v8::Local<v8::Context>,
                                                   v8::Isolate*);
   static v8::MaybeLocal<v8::Object> instantiateObject(

[jbroman, 2017/02/21 22:10:28]

You have deleted the definition of this function, so can you also delete the
declaration?

[adithyas, 2017/02/21 22:37:41]

Oops, forgot to do that.

       v8::Isolate*,
-      v8::Local<v8::ObjectTemplate>);
-  static v8::MaybeLocal<v8::Object> instantiateObject(
-      v8::Isolate*,
       v8::Local<v8::Function>,
       int argc = 0,
       v8::Local<v8::Value> argv[] = 0);
-  static v8::MaybeLocal<v8::Object> instantiateObjectInDocument(
-      v8::Isolate*,
-      v8::Local<v8::Function>,
-      ExecutionContext*,
-      int argc = 0,
-      v8::Local<v8::Value> argv[] = 0);
 
   static uint32_t tagForParserCache(CachedMetadataHandler*);
   static uint32_t tagForCodeCache(CachedMetadataHandler*);
   static void setCacheTimeStamp(CachedMetadataHandler*);
 
-  // Utiltiies for calling functions added to the V8 extras binding object.
+  // Utilities for calling functions added to the V8 extras binding object.
 
   template <size_t N>
   static v8::MaybeLocal<v8::Value> callExtra(ScriptState* scriptState,
                                              const char* name,
                                              v8::Local<v8::Value> (&args)[N]) {
     return callExtraHelper(scriptState, name, N, args);
   }
 
   template <size_t N>
   static v8::Local<v8::Value> callExtraOrCrash(
@@ skipping 21 matching lines @@
       return v8::MaybeLocal<v8::Value>();
     v8::Local<v8::Function> function = functionValue.As<v8::Function>();
     return V8ScriptRunner::callInternalFunction(function, undefined, numArgs,
                                                 args, isolate);
   }
 };
 
 }  // namespace blink
 
 #endif  // V8ScriptRunner_h