Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 27097002: Fixed bug in extractps instruction on ia32 and x64 (Closed)

Created:
7 years, 2 months ago by Weiliang
Modified:
7 years, 2 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Fixed bug in extractps instruction on ia32 and x64 Also fixed wrong roundsd instruction disassemble output BUG=

Patch Set 1 #

Patch Set 2 : Make disassemble operand output consistent and compact #

Patch Set 3 : added testcases #

Patch Set 4 : Fixed failure in debug mode test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -26 lines) Patch
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/ia32/disasm-ia32.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/disasm-x64.cc View 1 11 chunks +19 lines, -19 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 2 3 2 chunks +29 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Weiliang
Hi Yang, extractps is not used in current V8. I found this bug when prototyping ...
7 years, 2 months ago (2013-10-12 08:23:16 UTC) #1
Sven Panne
On 2013/10/12 08:23:16, Weiliang wrote: > Hi Yang, > extractps is not used in current ...
7 years, 2 months ago (2013-10-14 07:43:54 UTC) #2
Weiliang
On 2013/10/14 07:43:54, Sven Panne wrote: > On 2013/10/12 08:23:16, Weiliang wrote: > > Hi ...
7 years, 2 months ago (2013-10-15 07:45:56 UTC) #3
Sven Panne
lgtm
7 years, 2 months ago (2013-10-15 08:00:29 UTC) #4
Sven Panne
NOT LGTM, actually. :-/ This CL makes the test suite fail in debug mode due ...
7 years, 2 months ago (2013-10-15 12:35:55 UTC) #5
Weiliang
On 2013/10/15 12:35:55, Sven Panne wrote: > NOT LGTM, actually. :-/ This CL makes the ...
7 years, 2 months ago (2013-10-16 00:22:59 UTC) #6
Sven Panne
On 2013/10/16 00:22:59, Weiliang wrote: > Please try the new CL. :) There seems to ...
7 years, 2 months ago (2013-10-16 07:21:34 UTC) #7
Weiliang
7 years, 2 months ago (2013-10-16 08:24:51 UTC) #8
Message was sent while issue was closed.
On 2013/10/16 07:21:34, Sven Panne wrote:
> On 2013/10/16 00:22:59, Weiliang wrote:
> > Please try the new CL. :)
> 
> There seems to be a misunderstanding here: I landed
> https://code.google.com/p/v8/source/detail?r=17217 yesterday plus a follow-up
> fix https://code.google.com/p/v8/source/detail?r=17218. Is there anything to
be
> done after these CLs?

See, thanks~

Powered by Google App Engine
This is Rietveld 408576698