Chromium Code Reviews| Index: third_party/WebKit/Source/core/style/StyleDifference.h |
| diff --git a/third_party/WebKit/Source/core/style/StyleDifference.h b/third_party/WebKit/Source/core/style/StyleDifference.h |
| index 3003e61de8437994ee39652c49b2b7d2cf1a50f1..274e5846ee8ae77ce06dfdddffbd52b6c0f05cbb 100644 |
| --- a/third_party/WebKit/Source/core/style/StyleDifference.h |
| +++ b/third_party/WebKit/Source/core/style/StyleDifference.h |
| @@ -55,12 +55,21 @@ class StyleDifference { |
| return m_paintInvalidationType != NoPaintInvalidation; |
| } |
| + // The text selection needs paint invalidation. |
| + bool needsPaintInvalidationSelection() const { |
| + return m_paintInvalidationType == PaintInvalidationSelection; |
| + } |
| + void setNeedsPaintInvalidationSelection() { |
| + DCHECK(!needsPaintInvalidation()); |
|
mstensho (USE GERRIT)
2017/02/21 21:03:54
So, it looks like this one is failing in quite a f
rune
2017/02/21 21:42:00
Yes. This is fragile since it relies on order and
|
| + m_paintInvalidationType = PaintInvalidationSelection; |
| + } |
| + |
| // The object just needs to issue paint invalidations. |
| bool needsPaintInvalidationObject() const { |
| return m_paintInvalidationType == PaintInvalidationObject; |
| } |
| void setNeedsPaintInvalidationObject() { |
| - ASSERT(!needsPaintInvalidationSubtree()); |
| + DCHECK(!needsPaintInvalidationSubtree()); |
| m_paintInvalidationType = PaintInvalidationObject; |
| } |
| @@ -140,9 +149,10 @@ class StyleDifference { |
| private: |
| enum PaintInvalidationType { |
| - NoPaintInvalidation = 0, |
| + NoPaintInvalidation, |
| + PaintInvalidationSelection, |
| PaintInvalidationObject, |
| - PaintInvalidationSubtree |
| + PaintInvalidationSubtree, |
| }; |
| unsigned m_paintInvalidationType : 2; |